sync favorited item star color (#5086)

* sync favorited star color

* tweak color classes

frontend/src/metabase/questions/components/Item.jsx

@@ -133,9 +133,9 @@ const ItemBody = pure(({ entity, id, name, description, labels, favorite, collec
                 <Tooltip tooltip={favorite ? "Unfavorite" : "Favorite"}>
                     <Icon
                         className={cx(
-                            "flex cursor-pointer text-brand-hover transition-color",
-                            {"hover-child text-light-blue": !favorite},
-                            {"visible text-brand": favorite}
+                            "flex cursor-pointer",
+                            {"hover-child text-light-blue text-brand-hover": !favorite},
+                            {"visible text-gold": favorite}
                         )}
                         name={favorite ? "star" : "staroutline"}
                         size={ITEM_ICON_SIZE}