Enforce collection permissions in drag and drop. Pending backend modifications...

Enforce collection permissions in drag and drop. Pending backend modifications to include can_write in various places

frontend/src/metabase/components/CollectionLanding.jsx

@@ -212,13 +212,13 @@ class DefaultLanding extends React.Component {
                 <BrowserCrumbs
                   analyticsContext={ANALYTICS_CONTEXT}
                   crumbs={[
-                    ...ancestors.map(({ id, name }) => ({
+                    ...ancestors.map(ancestor => ({
                       title: (
-                        <CollectionDropTarget collection={{ id }} margin={8}>
-                          {name}
+                        <CollectionDropTarget collection={ancestor} margin={8}>
+                          {ancestor.name}
                         </CollectionDropTarget>
                       ),
-                      to: Urls.collection(id),
+                      to: Urls.collection(ancestor.id),
                     })),
                   ]}
                 />
@@ -261,7 +261,7 @@ class DefaultLanding extends React.Component {
                           className="relative"
                           key={index}
                         >
-                          <ItemDragSource item={item}>
+                          <ItemDragSource item={item} collection={collection}>
                             <PinnedItem
                               key={`${item.type}:${item.id}`}
                               index={index}
@@ -349,6 +349,7 @@ class DefaultLanding extends React.Component {
                                       <ItemDragSource
                                         item={item}
                                         selection={selection}
+                                        collection={collection}
                                       >
                                         <NormalItem
                                           key={`${item.type}:${item.id}`}

frontend/src/metabase/components/CollectionList.jsx

@@ -34,7 +34,10 @@ class CollectionList extends React.Component {
               <GridItem w={w} key={collection.id}>
                 <CollectionDropTarget collection={collection}>
                   {({ highlighted, hovered }) => (
-                    <ItemDragSource item={collection}>
+                    <ItemDragSource
+                      item={collection}
+                      collection={currentCollection}
+                    >
                       <CollectionItem
                         collection={collection}
                         highlighted={highlighted}

frontend/src/metabase/containers/dnd/CollectionDropTarget.jsx

@@ -11,6 +11,10 @@ const CollectionDropTarget = DropTarget(
     },
     canDrop(props, monitor) {
       const { item } = monitor.getItem();
+      // can't drop if can't write the  collection
+      if (props.collection.can_write === false) {
+        return false;
+      }
       return item.model !== "collection" || item.id !== props.collection.id;
     },
   },

frontend/src/metabase/containers/dnd/ItemDragSource.jsx

@@ -9,6 +9,10 @@ import { dragTypeForItem } from ".";
   props => dragTypeForItem(props.item),
   {
     canDrag(props, monitor) {
+      // can't drag if can't write the parent collection
+      if (props.collection && props.collection.can_write === false) {
+        return false;
+      }
       // if items are selected only allow dragging selected items
       if (
         props.selection &&

frontend/src/metabase/containers/dnd/PinDropTarget.jsx

@@ -13,6 +13,8 @@ const PinDropTarget = DropTarget(
     },
     canDrop(props, monitor) {
       const { item } = monitor.getItem();
+      // NOTE: not necessary to check collection permission here since we
+      // enforce it when beginning to drag and item within the same collection
       return props.pinIndex != item.collection_position;
     },
   },