-
- Downloads
backport: resolve conflicts in js_test.cljs (#47325)
Resolved conflicts in legacy-ref-test related to a metrics test that depends on changes that weren't backported. Relevant unbackported changes in 460ac41f Conflicts: test/metabase/lib/js_test.cljs Ensure that CI checks fail if cljs tests fail (#47192) * Fix typo in expression-clause-normalization-test s/time-interval/relative-time-interval/ * Add missing table-id to card def to fix failing legacy-ref-test * Ensure that if yarn test-cljs fails it fails the CI checks When configured to autorun, the command shadow-cljs compile test will exit success even if test failures occur in the node test. See https://github.com/thheller/shadow-cljs/issues/425 In order to ensure our CI checks fail when cljs tests fail, we need to invoke node directly. To prevent running the tests twice, remove `:autorun true` from the `:test` target in shadow-cljs.edn. Co-authored-by:appleby <86076+appleby@users.noreply.github.com>
Loading
Please register or sign in to comment