Do not reload settings on error when explicit Save is used (#17123)

frontend/src/metabase/admin/settings/settings.js

@@ -87,8 +87,6 @@ export const updateEmailSettings = createThunkAction(
       } catch (error) {
         console.log("error updating email settings", settings, error);
         throw error;
-      } finally {
-        await dispatch(reloadSettings());
       }
     };
   },
@@ -124,8 +122,6 @@ export const updateSlackSettings = createThunkAction(
       } catch (error) {
         console.log("error updating slack settings", settings, error);
         throw error;
-      } finally {
-        await dispatch(reloadSettings());
       }
     };
   },
@@ -143,8 +139,6 @@ export const updateLdapSettings = createThunkAction(
       } catch (error) {
         console.log("error updating LDAP settings", settings, error);
         throw error;
-      } finally {
-        await dispatch(reloadSettings());
       }
     };
   },

frontend/test/metabase/scenarios/admin/settings/sso/ldap.cy.spec.js

@@ -52,7 +52,7 @@ describe("scenarios > admin > settings > SSO > LDAP", () => {
     cy.button("Changes saved!");
   });
 
-  it.skip("should not reset previously populated fields when validation fails for just one of them (metabase#16226)", () => {
+  it("should not reset previously populated fields when validation fails for just one of them (metabase#16226)", () => {
     cy.findByPlaceholderText("ldap.yourdomain.org").type("foobar");
     cy.findByPlaceholderText("389").type("baz");
     cy.button("Save changes").click();