Simplify FieldValuesWidget fetching/option-handling logic (#22990)
* Move caching logic out of FieldValuesWidget * Try to clean up/centralize field value fetching * Move dup logic to fetchValues * Alwyas rely on option in component state * Simplify hasList * Make unit tests async * Fix test import * Fix outdated prop reference * fix remappings * Fix dashboard action unit tests
Showing
- frontend/src/metabase/components/FieldValuesWidget.jsx 104 additions, 152 deletionsfrontend/src/metabase/components/FieldValuesWidget.jsx
- frontend/src/metabase/dashboard/actions.js 16 additions, 4 deletionsfrontend/src/metabase/dashboard/actions.js
- frontend/src/metabase/dashboard/actions.unit.spec.js 13 additions, 13 deletionsfrontend/src/metabase/dashboard/actions.unit.spec.js
- frontend/src/metabase/dashboard/reducers.js 2 additions, 2 deletionsfrontend/src/metabase/dashboard/reducers.js
- frontend/test/metabase/components/FieldValuesWidget.unit.spec.js 21 additions, 20 deletions...d/test/metabase/components/FieldValuesWidget.unit.spec.js
Loading
Please register or sign in to comment