-
- Downloads
Add validation logic to TemplateTagDimension dimension tag handling (#20878)
* Add validation logic to TemplateTagDimension dimension tag handling * Add basic error message to query builder * Update error text * Add unique error message for validation errors * Update text of error state Co-authored-by:Maz Ameli <maz@metabase.com> * Fix types * Fix NativeQuery unit test * Add unit tests for new components Co-authored-by:
Maz Ameli <maz@metabase.com>
Showing
- frontend/src/metabase-lib/lib/Dimension.ts 26 additions, 4 deletionsfrontend/src/metabase-lib/lib/Dimension.ts
- frontend/src/metabase-lib/lib/ValidationError.ts 14 additions, 0 deletionsfrontend/src/metabase-lib/lib/ValidationError.ts
- frontend/src/metabase-lib/lib/queries/NativeQuery.ts 30 additions, 4 deletionsfrontend/src/metabase-lib/lib/queries/NativeQuery.ts
- frontend/src/metabase/query_builder/components/QueryValidationError/ErrorActionButton.tsx 64 additions, 0 deletions...der/components/QueryValidationError/ErrorActionButton.tsx
- frontend/src/metabase/query_builder/components/QueryValidationError/ErrorActionButton.unit.spec.tsx 103 additions, 0 deletions...ents/QueryValidationError/ErrorActionButton.unit.spec.tsx
- frontend/src/metabase/query_builder/components/QueryValidationError/QueryValidationError.styled.tsx 34 additions, 0 deletions...ents/QueryValidationError/QueryValidationError.styled.tsx
- frontend/src/metabase/query_builder/components/QueryValidationError/QueryValidationError.tsx 36 additions, 0 deletions.../components/QueryValidationError/QueryValidationError.tsx
- frontend/src/metabase/query_builder/components/QueryValidationError/QueryValidationError.unit.spec.tsx 53 additions, 0 deletions...s/QueryValidationError/QueryValidationError.unit.spec.tsx
- frontend/src/metabase/query_builder/components/QueryValidationError/index.ts 1 addition, 0 deletions...se/query_builder/components/QueryValidationError/index.ts
- frontend/src/metabase/query_builder/components/view/View.jsx 19 additions, 11 deletionsfrontend/src/metabase/query_builder/components/view/View.jsx
- frontend/test/metabase-lib/lib/Dimension.unit.spec.js 72 additions, 0 deletionsfrontend/test/metabase-lib/lib/Dimension.unit.spec.js
- frontend/test/metabase-lib/lib/queries/NativeQuery.unit.spec.js 1 addition, 0 deletions...nd/test/metabase-lib/lib/queries/NativeQuery.unit.spec.js
Loading
Please register or sign in to comment