Fix object detail browsing (#20101)
* Group `Urls.question` args into object * Use `Urls.serializedQuestion` * Fix `tableRowsQuery` URL builder * Add E2E tests * Add routes with `/:objectId` * Add `objectId` support to question URL builders * Use `queryParams` from `location` in QB init * Fix `useSyncedQueryString` drops other params * Add `zoomInRow` action * Add `resetRowZoom` action * Add basic selectors * Modify `getIsObjectDetail` selector * Handle `objectId` during QB init * Replace actions opening prev/next object detail * Use zoomed row in object detail view * Update `ObjectDetailDrill` * Fix URLs update for detail views * Handle browser "back" button in detail view * Use question name as a fallback for object view title field * Fix E2E tests * Fix E2E test * Fix routes order * Fix opening a link to filtered out record * Move tests for object details * Fix regexp * Fix link style * Better routing handling
Showing
- frontend/src/metabase/hooks/use-synced-query-string.ts 15 additions, 1 deletionfrontend/src/metabase/hooks/use-synced-query-string.ts
- frontend/src/metabase/lib/card.js 0 additions, 7 deletionsfrontend/src/metabase/lib/card.js
- frontend/src/metabase/lib/urls.js 13 additions, 8 deletionsfrontend/src/metabase/lib/urls.js
- frontend/src/metabase/modes/components/drill/ObjectDetailDrill.jsx 68 additions, 15 deletions...src/metabase/modes/components/drill/ObjectDetailDrill.jsx
- frontend/src/metabase/query_builder/actions.js 53 additions, 45 deletionsfrontend/src/metabase/query_builder/actions.js
- frontend/src/metabase/query_builder/containers/QueryBuilder.jsx 1 addition, 5 deletions...nd/src/metabase/query_builder/containers/QueryBuilder.jsx
- frontend/src/metabase/query_builder/reducers.js 16 additions, 0 deletionsfrontend/src/metabase/query_builder/reducers.js
- frontend/src/metabase/query_builder/selectors.js 98 additions, 3 deletionsfrontend/src/metabase/query_builder/selectors.js
- frontend/src/metabase/query_builder/utils.js 31 additions, 0 deletionsfrontend/src/metabase/query_builder/utils.js
- frontend/src/metabase/routes.jsx 2 additions, 0 deletionsfrontend/src/metabase/routes.jsx
- frontend/src/metabase/visualizations/components/ChartClickActions.jsx 1 addition, 12 deletions.../metabase/visualizations/components/ChartClickActions.jsx
- frontend/src/metabase/visualizations/visualizations/ObjectDetail.jsx 108 additions, 43 deletions...c/metabase/visualizations/visualizations/ObjectDetail.jsx
- frontend/test/metabase/lib/urls.unit.spec.js 31 additions, 0 deletionsfrontend/test/metabase/lib/urls.unit.spec.js
- frontend/test/metabase/modes/components/drill/ObjectDetailDrill.unit.spec.js 102 additions, 19 deletions...ase/modes/components/drill/ObjectDetailDrill.unit.spec.js
- frontend/test/metabase/scenarios/dashboard/dashboard-drill.cy.spec.js 2 additions, 2 deletions...t/metabase/scenarios/dashboard/dashboard-drill.cy.spec.js
- frontend/test/metabase/scenarios/question/new.cy.spec.js 7 additions, 7 deletionsfrontend/test/metabase/scenarios/question/new.cy.spec.js
- frontend/test/metabase/scenarios/visualizations/object_detail.cy.spec.js 110 additions, 21 deletions...etabase/scenarios/visualizations/object_detail.cy.spec.js
Loading
Please register or sign in to comment