-
- Downloads
Fix - Notebook expression editor autocomplete issues (#49949) (#50274)
* Allow navigating with arrow up/down between lines in expression editor
* Do not hijack up/down arrow keys for autocomplete suggestions navigation when there's only 1 suggestion
* Add explanatory comments
* Convert tokenizer to TS
* Add a test
* Format code
* Add basic test case
* Fix a deprecation
* Handle incomplete bracket identifier tokens
* Shorten code
* Add comment
* Fix suggestion not always getting selected
* Fix computation
* Fix types
* Update comment
* Add repros for #49882
* Add repro
* Fix comment
* Deprecate a HOC
* Update assertion
* Remove _.compose and default export
* Fix types in ExplicitSize
* Fix typing in ExpressionEditorTextfield
* Fix types
* Fix error handling
* Fix showing errors when expression is invalid
* Do not submit null expressions
* Fix typing
* Update assertion
* Fix flaky test
* Fix filter
* Decrease flakiness
* Fix crashing
* Add comment
* Fix incomplete bracket idenfitiers
* Fix type
* Improve typing
* Add an explanatory comment
Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
Showing
- e2e/test/scenarios/custom-column/custom-column-reproductions.cy.spec.js 76 additions, 0 deletions...rios/custom-column/custom-column-reproductions.cy.spec.js
- frontend/src/metabase-lib/v1/expressions/diagnostics.ts 1 addition, 8 deletionsfrontend/src/metabase-lib/v1/expressions/diagnostics.ts
- frontend/src/metabase-lib/v1/expressions/pratt/parser.ts 4 additions, 1 deletionfrontend/src/metabase-lib/v1/expressions/pratt/parser.ts
- frontend/src/metabase-lib/v1/expressions/tokenizer.ts 90 additions, 59 deletionsfrontend/src/metabase-lib/v1/expressions/tokenizer.ts
- frontend/src/metabase-lib/v1/expressions/tokenizer.unit.spec.ts 37 additions, 0 deletions...nd/src/metabase-lib/v1/expressions/tokenizer.unit.spec.ts
- frontend/src/metabase-lib/v1/expressions/types.ts 7 additions, 0 deletionsfrontend/src/metabase-lib/v1/expressions/types.ts
- frontend/src/metabase/components/ExplicitSize/ExplicitSize.tsx 3 additions, 0 deletions...end/src/metabase/components/ExplicitSize/ExplicitSize.tsx
- frontend/src/metabase/core/components/TabRow/TabRow.tsx 10 additions, 5 deletionsfrontend/src/metabase/core/components/TabRow/TabRow.tsx
- frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield/ExpressionEditorTextfield.tsx 53 additions, 38 deletions...s/ExpressionEditorTextfield/ExpressionEditorTextfield.tsx
- frontend/src/metabase/query_builder/components/expressions/ExpressionEditorTextfield/index.ts 1 addition, 1 deletion...components/expressions/ExpressionEditorTextfield/index.ts
- frontend/src/metabase/query_builder/components/expressions/ExpressionWidget.tsx 21 additions, 5 deletions...query_builder/components/expressions/ExpressionWidget.tsx
Loading
Please register or sign in to comment