-
- Downloads
Fixing x-rays with custom columns (#16680) (#35336)
* Fixing x-rays with custom columns (#16680) Queries with custom columns were broken for two reasons: - When names were computed for display, the humanization code expected fields - The generated dashcard queries did not preserve the base query's custom expression definitions For the first point, the code in `metabase.automagic-dashboards.names` was generalized for both fields and expressions. For the second, the logic that was formerly `preserve-joins` in `metabase.automagic-dashboards.core` has been generalized to `preserve-entity-element` and applied to both joins and expressions. * Renamed innner `splice-joins` to `splice-elements` * Updating `preserve-entity-element` to retain any existing element that is already present in the old query. * Reinstated inline tru strings such as "is less than" so they can be internationalized. * Added e2e test * Adding .click() to e2e test.
Showing
- e2e/test/scenarios/custom-column/custom-column.cy.spec.js 27 additions, 0 deletionse2e/test/scenarios/custom-column/custom-column.cy.spec.js
- frontend/src/metabase-lib/queries/drills/automatic-insights-drill.ts 1 addition, 10 deletions...c/metabase-lib/queries/drills/automatic-insights-drill.ts
- src/metabase/automagic_dashboards/core.clj 12 additions, 8 deletionssrc/metabase/automagic_dashboards/core.clj
- src/metabase/automagic_dashboards/names.clj 56 additions, 37 deletionssrc/metabase/automagic_dashboards/names.clj
- src/metabase/automagic_dashboards/util.clj 0 additions, 15 deletionssrc/metabase/automagic_dashboards/util.clj
- test/metabase/automagic_dashboards/core_test.clj 99 additions, 0 deletionstest/metabase/automagic_dashboards/core_test.clj
- test/metabase/automagic_dashboards/names_test.clj 12 additions, 0 deletionstest/metabase/automagic_dashboards/names_test.clj
Loading
Please register or sign in to comment