Skip to content
Snippets Groups Projects
Unverified Commit 5f02f323 authored by Mark Bastian's avatar Mark Bastian Committed by GitHub
Browse files

Fixing x-rays with custom columns (#16680) (#35336)

* Fixing x-rays with custom columns (#16680)

Queries with custom columns were broken for two reasons:
- When names were computed for display, the humanization code expected fields
- The generated dashcard queries did not preserve the base query's custom expression definitions

For the first point, the code in `metabase.automagic-dashboards.names` was generalized for both fields and expressions.

For the second, the logic that was formerly `preserve-joins` in `metabase.automagic-dashboards.core` has been generalized to `preserve-entity-element` and applied to both joins and expressions.

* Renamed innner `splice-joins` to `splice-elements`

* Updating `preserve-entity-element` to retain any existing element that is already present in the old query.

* Reinstated inline tru strings such as "is less than" so they can be internationalized.

* Added e2e test

* Adding .click() to e2e test.
parent d2ecd17b
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment