Hide redundant border in question details sidebar (#21999)

enterprise/frontend/src/metabase-enterprise/moderation/index.js

@@ -12,6 +12,7 @@ import {
 
 if (hasPremiumFeature("content_management")) {
   Object.assign(PLUGIN_MODERATION, {
+    isEnabled: () => true,
     QuestionModerationSection,
     ModerationStatusIcon,
     getStatusIconForQuestion,

frontend/src/metabase/plugins/index.ts

@@ -103,6 +103,7 @@ export const PLUGIN_COLLECTION_COMPONENTS = {
 };
 
 export const PLUGIN_MODERATION = {
+  isEnabled: () => false,
   QuestionModerationSection: PluginPlaceholder,
   ModerationStatusIcon: PluginPlaceholder,
   getStatusIconForQuestion: object,

frontend/src/metabase/query_builder/components/view/sidebars/QuestionDetailsSidebarPanel.jsx

@@ -38,6 +38,9 @@ function QuestionDetailsSidebarPanel({
       }
     : undefined;
 
+  const hasSecondarySection =
+    (isDataset && canWrite) || (!isDataset && PLUGIN_MODERATION.isEnabled());
+
   return (
     <Container>
       <SidebarPaddedContent>
@@ -53,18 +56,20 @@ function QuestionDetailsSidebarPanel({
           description={description}
           onEdit={onDescriptionEdit}
         />
-        <BorderedSectionContainer>
-          {isDataset && canWrite && (
-            <DatasetManagementSection dataset={question} />
-          )}
-          {!isDataset && (
-            <ModerationSectionContainer>
-              <PLUGIN_MODERATION.QuestionModerationSection
-                question={question}
-              />
-            </ModerationSectionContainer>
-          )}
-        </BorderedSectionContainer>
+        {hasSecondarySection && (
+          <BorderedSectionContainer>
+            {isDataset && canWrite && (
+              <DatasetManagementSection dataset={question} />
+            )}
+            {!isDataset && (
+              <ModerationSectionContainer>
+                <PLUGIN_MODERATION.QuestionModerationSection
+                  question={question}
+                />
+              </ModerationSectionContainer>
+            )}
+          </BorderedSectionContainer>
+        )}
       </SidebarPaddedContent>
       <QuestionActivityTimeline question={question} />
     </Container>