Skip to content

GitLab

Explore

Sign in

Primary navigation

Project

M

Metabase
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Environments
- Terraform modules
- Incidents
- Service Desk

Snippets Groups Projects

61bfcb85

Unverified Commit 61bfcb85 authored 3 years ago by Anton Kulyk Committed by GitHub 3 years ago

Downloads
- Patches
- Plain Diff

Fix notebook editor crash when joining on a custom column (#18845)

* Add repro for #18818

* Fix date time field check in JoinStep

parent 48e78559

Branches

Tags

No related merge requests found

Changes 2

Hide whitespace changes

Inline Side-by-side

Showing

frontend/src/metabase/query_builder/components/notebook/steps/JoinStep.jsx 1 addition, 1 deletion

...base/query_builder/components/notebook/steps/JoinStep.jsx
frontend/test/metabase/scenarios/question/reproductions/18818-crash-when-joining-on-custom-column.cy.spec.js 41 additions, 0 deletions

...ions/18818-crash-when-joining-on-custom-column.cy.spec.js

with 42 additions and 1 deletion

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment