Changed to clojure style and fixed indentation

src/metabase/query_processor/middleware/parameters/sql.clj

@@ -154,9 +154,8 @@
 (s/defn ^:private default-value-for-dimension :- (s/maybe DimensionValue)
   "Return the default value for a Dimension (Field Filter) param defined by the map TAG, if one is set."
   [tag :- TagParam]
-  (or (:default tag)
-      (when (:required tag)
-        (throw (Exception. (str (tru "''{0}'' is a required param." (:display-name tag)))))))
+  (when (and (:required tag) (not (:default tag)))
+    (throw (Exception. (str (tru "''{0}'' is a required param." (:display-name tag))))))
   (when-let [default (:default tag)]
     {:type   (:widget-type tag :dimension)             ; widget-type is the actual type of the default value if set
      :target [:dimension [:template-tag (:name tag)]]

test/metabase/query_processor/middleware/parameters/sql_test.clj

@@ -321,9 +321,9 @@
 
 ;; dimension -- required but unspecified
 (expect Exception
-            (into {} (#'sql/value-for-tag {:name "checkin_date", :display-name "Checkin Date", :type "dimension", :required true,
-                                           :dimension ["field-id" (data/id :checkins :date)]}
-                                          nil)))
+        (into {} (#'sql/value-for-tag {:name "checkin_date", :display-name "Checkin Date", :type "dimension", :required true,
+                                       :dimension ["field-id" (data/id :checkins :date)]}
+                                      nil)))
 
 ;; dimension -- required and default specified
 (expect