Remove archived actions from api/action/public results (#28307)

src/metabase/api/action.clj

@@ -63,7 +63,7 @@
   []
   (validation/check-has-application-permission :setting)
   (validation/check-public-sharing-enabled)
-  (db/select [Action :name :id :public_uuid :model_id], :public_uuid [:not= nil]))
+  (db/select [Action :name :id :public_uuid :model_id], :public_uuid [:not= nil], :archived false))
 
 (api/defendpoint GET "/:action-id"
   [action-id]

test/metabase/api/action_test.clj

@@ -280,7 +280,11 @@
                    (mt/user-http-request :rasta :get 403 "action/public"))))
           (testing "Test that superusers can fetch a list of publicly-accessible actions"
             (is (= [{:name "Test action" :id action-id :public_uuid (:public_uuid action-opts) :model_id model-id}]
-                   (filter #(= (:id %) action-id) (mt/user-http-request :crowberto :get 200 "action/public"))))))))))
+                   (filter #(= (:id %) action-id) (mt/user-http-request :crowberto :get 200 "action/public"))))))
+        (testing "We cannot fetch an archived action"
+          (mt/with-actions [{} (assoc action-opts :archived true)]
+            (is (= []
+                   (mt/user-http-request :crowberto :get 200 "action/public")))))))))
 
 (deftest share-action-test
   (testing "POST /api/action/:id/public_link"