-
- Downloads
Allow editing the breakout bin from the compare aggregation picker and provide presets (#46844)
* Add offset presets * Render OffsetPresets initially * Add BucketInput * Render BucketInput and do not rely on referential equality for Lib.Bucket * Make sure the currently selected bucket shows in the presets * Lift label into CompareAggregations * Fix spacing of label * Fix labels based on comparison type * Use Switch for include current period * Include current bucket in CurrentPeriodInput label * Fix unit tests * Add more unit tests for CompareAggregations * Update e2e test for column compare to handle presets * Group offset tests * Add tests for moving average * Add tests to verify changing the bucket works * Fix type * Make sure temporal columns are buckatable before picking them * Make getPreferredPresets more clear * Add test for temporal expression column * Fix lint
Showing
- e2e/test/scenarios/question/column-compare.cy.spec.ts 1443 additions, 586 deletionse2e/test/scenarios/question/column-compare.cy.spec.ts
- frontend/src/metabase/common/components/AggregationPicker/AggregationPicker.unit.spec.tsx 43 additions, 0 deletions...ponents/AggregationPicker/AggregationPicker.unit.spec.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/CompareAggregations.tsx 68 additions, 15 deletions...er/components/CompareAggregations/CompareAggregations.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/CompareAggregations.unit.spec.tsx 148 additions, 43 deletions...nts/CompareAggregations/CompareAggregations.unit.spec.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/components/BucketInput/BucketInput.tsx 81 additions, 0 deletions...ompareAggregations/components/BucketInput/BucketInput.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/components/BucketInput/index.tsx 1 addition, 0 deletions...ents/CompareAggregations/components/BucketInput/index.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/components/CurrentPeriodInput/CurrentPeriodInput.tsx 11 additions, 4 deletions...ions/components/CurrentPeriodInput/CurrentPeriodInput.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/components/OffsetInput/OffsetInput.module.css 0 additions, 9 deletions...ggregations/components/OffsetInput/OffsetInput.module.css
- frontend/src/metabase/query_builder/components/CompareAggregations/components/OffsetInput/OffsetInput.tsx 14 additions, 37 deletions...ompareAggregations/components/OffsetInput/OffsetInput.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/components/OffsetInput/utils.ts 0 additions, 50 deletions...nents/CompareAggregations/components/OffsetInput/utils.ts
- frontend/src/metabase/query_builder/components/CompareAggregations/components/OffsetPresets/OffsetPresets.tsx 105 additions, 0 deletions...reAggregations/components/OffsetPresets/OffsetPresets.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/components/OffsetPresets/index.tsx 1 addition, 0 deletions...ts/CompareAggregations/components/OffsetPresets/index.tsx
- frontend/src/metabase/query_builder/components/CompareAggregations/components/index.ts 2 additions, 0 deletions...uilder/components/CompareAggregations/components/index.ts
- frontend/src/metabase/query_builder/components/CompareAggregations/utils.ts 30 additions, 13 deletions...ase/query_builder/components/CompareAggregations/utils.ts
Loading
Please register or sign in to comment