feat(sdk): refactor the auth code to provide better error messages (#49214)
* refactor + more specific auth errors * fix linting issues * make tests pass, again * make test pass for real? * continues the refactor and hopefully makes tests pass * try to simplify the logic a little bit more * also logs to the console for the edge case of invalid session * remove setLoginStatus * fix typo * fix debug line that should have been commented * remove dead code * remove test for code that doesnt exist * address feedback from PR * update test copy * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * update copy for site settings error * ex -> exception * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * Update enterprise/frontend/src/embedding-sdk/store/auth.ts Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev> * update tests to use the updated copy + small typos * refactor: use jest spy on to check for console.error Co-authored-by:
"Mahatthana (Kelvin) Nomsawadi" <me@bboykelvin.dev> * use full error message in test * renamed response to session * mock implementation of console.log * fix(49482): don't create a new store on each MetabaseProvider render (#49492) * fix(49482): don't create a new store on each MetabaseProvider render * remove store prop as it seems to not be used --------- Co-authored-by:
Mahatthana (Kelvin) Nomsawadi <me@bboykelvin.dev>
Showing
- e2e/test/scenarios/embedding-sdk/metabase-sdk-styles-tests.cy.spec.ts 5 additions, 3 deletions...narios/embedding-sdk/metabase-sdk-styles-tests.cy.spec.ts
- e2e/test/scenarios/embedding-sdk/static-dashboard-cors.cy.spec.js 2 additions, 2 deletions.../scenarios/embedding-sdk/static-dashboard-cors.cy.spec.js
- enterprise/frontend/src/embedding-sdk/components/private/PublicComponentWrapper/PublicComponentWrapper.tsx 0 additions, 4 deletions...private/PublicComponentWrapper/PublicComponentWrapper.tsx
- enterprise/frontend/src/embedding-sdk/components/private/PublicComponentWrapper/PublicComponentWrapper.unit.spec.tsx 0 additions, 6 deletions...blicComponentWrapper/PublicComponentWrapper.unit.spec.tsx
- enterprise/frontend/src/embedding-sdk/components/public/MetabaseProvider.tsx 13 additions, 9 deletions.../src/embedding-sdk/components/public/MetabaseProvider.tsx
- enterprise/frontend/src/embedding-sdk/hooks/private/index.ts 0 additions, 1 deletionenterprise/frontend/src/embedding-sdk/hooks/private/index.ts
- enterprise/frontend/src/embedding-sdk/hooks/private/setup-sdk-auth.ts 0 additions, 50 deletions...rontend/src/embedding-sdk/hooks/private/setup-sdk-auth.ts
- enterprise/frontend/src/embedding-sdk/hooks/private/setup-sdk-auth.unit.spec.tsx 0 additions, 63 deletions.../embedding-sdk/hooks/private/setup-sdk-auth.unit.spec.tsx
- enterprise/frontend/src/embedding-sdk/hooks/private/use-init-data.ts 31 additions, 64 deletions...frontend/src/embedding-sdk/hooks/private/use-init-data.ts
- enterprise/frontend/src/embedding-sdk/hooks/private/use-init-data.unit.spec.tsx 10 additions, 4 deletions...c/embedding-sdk/hooks/private/use-init-data.unit.spec.tsx
- enterprise/frontend/src/embedding-sdk/store/auth.ts 158 additions, 0 deletionsenterprise/frontend/src/embedding-sdk/store/auth.ts
- enterprise/frontend/src/embedding-sdk/store/reducer.ts 26 additions, 54 deletionsenterprise/frontend/src/embedding-sdk/store/reducer.ts
- enterprise/frontend/src/embedding-sdk/store/refresh-token.ts 0 additions, 14 deletionsenterprise/frontend/src/embedding-sdk/store/refresh-token.ts
- enterprise/frontend/src/embedding-sdk/store/types.ts 0 additions, 4 deletionsenterprise/frontend/src/embedding-sdk/store/types.ts
- enterprise/frontend/src/embedding-sdk/test/auth-flow.unit.spec.tsx 34 additions, 2 deletions...e/frontend/src/embedding-sdk/test/auth-flow.unit.spec.tsx
- enterprise/frontend/src/embedding-sdk/test/sdk-config-errors.unit.spec.tsx 154 additions, 0 deletions...nd/src/embedding-sdk/test/sdk-config-errors.unit.spec.tsx
Loading
Please register or sign in to comment