Skip to content
Snippets Groups Projects
Unverified Commit 652fafea authored by Oisin Coveney's avatar Oisin Coveney Committed by GitHub
Browse files

fix(sdk): Fix visualization default size (#49672)

parent a4828dc9
No related branches found
No related tags found
No related merge requests found
import cx from "classnames";
import { t } from "ttag";
import { FlexibleSizeComponent } from "embedding-sdk";
import {
SdkError,
SdkLoader,
} from "embedding-sdk/components/private/PublicComponentWrapper";
import type { FlexibleSizeProps } from "embedding-sdk/components/private/util/FlexibleSizeComponent";
import CS from "metabase/css/core/index.css";
import QueryVisualization from "metabase/query_builder/components/QueryVisualization";
import type Question from "metabase-lib/v1/Question";
import { useInteractiveQuestionContext } from "../context";
export const QuestionVisualization = () => {
export const QuestionVisualization = ({
height,
width,
className,
style,
}: FlexibleSizeProps) => {
const {
question,
queryResults,
......@@ -35,22 +42,29 @@ export const QuestionVisualization = () => {
const card = question.card();
return (
<QueryVisualization
className={cx(CS.flexFull, CS.fullWidth, CS.fullHeight)}
question={question}
rawSeries={[{ card, data: result && result.data }]}
isRunning={isQueryRunning}
isObjectDetail={false}
isResultDirty={false}
isNativeEditorOpen={false}
result={result}
noHeader
mode={mode}
navigateToNewCardInsideQB={navigateToNewCard}
onNavigateBack={onNavigateBack}
onUpdateQuestion={(question: Question) =>
updateQuestion(question, { run: false })
}
/>
<FlexibleSizeComponent
height={height}
width={width}
className={className}
style={style}
>
<QueryVisualization
className={cx(CS.flexFull, CS.fullWidth, CS.fullHeight)}
question={question}
rawSeries={[{ card, data: result && result.data }]}
isRunning={isQueryRunning}
isObjectDetail={false}
isResultDirty={false}
isNativeEditorOpen={false}
result={result}
noHeader
mode={mode}
navigateToNewCardInsideQB={navigateToNewCard}
onNavigateBack={onNavigateBack}
onUpdateQuestion={(question: Question) =>
updateQuestion(question, { run: false })
}
/>
</FlexibleSizeComponent>
);
};
......@@ -45,7 +45,9 @@ const ContentView = ({
.with("editor", () => (
<InteractiveQuestion.Editor onApply={onReturnToVisualization} />
))
.otherwise(() => <InteractiveQuestion.QuestionVisualization />);
.otherwise(() => (
<InteractiveQuestion.QuestionVisualization height="100%" />
));
export const InteractiveQuestionResult = ({
height,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment