Skip to content
Snippets Groups Projects
Unverified Commit 6548584c authored by Mahatthana (Kelvin) Nomsawadi's avatar Mahatthana (Kelvin) Nomsawadi Committed by GitHub
Browse files

Fix long running queries possibly piling up via auto-refresh (#32754)

* Simplify the code that fixes dashboard tab race condition

Remove a part of dashboard reducer that addressed the race condition
from https://github.com/metabase/metabase/pull/31578/files#r1240203745.

I revert the code back to make it simpler and fix the race condition by
calling certain actions in the right order.

* Update the todo comment to use more standard todo tag

* Prevent fetching a dashcard when the previous API isn't done and is auto-refresh

* Only skip loading new dashcard on dashcoard auto refresh

* fixup! Simplify the code that fixes dashboard tab race condition

* Clean up dashboard action

Rename an action with misleading name

* Make the boolean flag easier to understand

* fixup! Make the boolean flag easier to understand

* Add E2E

* Remove commented out code

* Correct `startTime` behavior

* Fix the case when navigating between dashboards

* Make isRefreshing logic easier to follow

* Fix failed unit tests
parent b24f62e6
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment