Skip to content
Snippets Groups Projects
Unverified Commit 65932665 authored by Cam Saul's avatar Cam Saul Committed by GitHub
Browse files

Test init code: read driver parents from driver deps.edn (#17612)

* Test init code: read driver parents from driver deps.edn

* Rename :metabase.build-driver/parents -> :metabase.driver/parents
parent 404e6f88
No related branches found
No related tags found
No related merge requests found
......@@ -25,7 +25,7 @@
(set (keys (:libs metabase-core-basis))))
(defn driver-parents [driver edition]
(when-let [parents (not-empty (:metabase.build-driver/parents (c/driver-edn driver edition)))]
(when-let [parents (not-empty (:metabase.driver/parents (c/driver-edn driver edition)))]
(u/announce "Driver has parent drivers %s" (pr-str parents))
parents))
......
......@@ -7,4 +7,4 @@
;; keep this synced with bigquery-cloud-sdk driver dependency version
com.google.http-client/google-http-client-jackson2 {:mvn/version "1.39.2"}}
:metabase.build-driver/parents #{:google}}
:metabase.driver/parents #{:google}}
google
......@@ -3,4 +3,4 @@
:deps
{com.google.apis/google-api-services-analytics {:mvn/version "v3-rev20180622-1.27.0"}}
:metabase.build-driver/parents #{:google}}
:metabase.driver/parents #{:google}}
google
......@@ -4,5 +4,5 @@
:deps
{com.facebook.presto/presto-jdbc {:mvn/version "0.260"}}
:metabase.build-driver/parents
:metabase.driver/parents
#{:presto-common}}
presto-common
{:paths ["src" "resources"]
:metabase.build-driver/parents #{:presto-common}}
:metabase.driver/parents #{:presto-common}}
presto-common
(ns metabase.test.initialize.plugins
(:require [clojure.java.io :as io]
[clojure.string :as str]
[clojure.tools.reader.edn :as edn]
[metabase.plugins :as plugins]
[metabase.plugins.initialize :as plugins.init]
[metabase.test.data.env.impl :as tx.env.impl]
......@@ -26,10 +26,14 @@
nm))
(yaml/parse-string (slurp manifest))))))))
(defn- driver-parents [driver]
(let [parents-file (io/file (format "modules/drivers/%s/parents" (name driver)))]
(when (.exists parents-file)
(str/split-lines (slurp parents-file)))))
(defn- driver-parents
"Return the set of parents for `driver`. Based on the value of `:metabase.driver/parents` in its `deps.edn`
file."
[driver]
(let [driver-deps-edn-file (io/file (format "modules/drivers/%s/deps.edn" (name driver)))]
(when (.exists driver-deps-edn-file)
(let [edn (edn/read-string (slurp driver-deps-edn-file))]
(:metabase.driver/parents edn)))))
(defn- load-plugin-manifests!
"When running tests driver plugins aren't loaded the normal way -- instead, to keep things sane, we simply merge their
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment