Sql autocomplete options (#24693)
* `sql-editor-autocomplete-match-style` options for perf
Large instances with 100ks of fields are choking on the select name from
fields where name like "%search-term%`. Version in 43 was
acceptable. This adds back the behavior in 43: prefix searching.
Also adds ability to turn off if even the prefix search is burdensome.
* Rename autocomplete-suggestion param `search` -> `substring`
* support sql-editor-autocomplete-match-style on the FE
* fix substring shows placeholder
* Ensure using prefix style matching in e2e test
* Make autocomplete style public
* Rename defsetting to have "native-query" in name, not sql
generally true. Consider mongo which has a native editor but no notion
of SQL
Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com>
Showing
- frontend/src/metabase/admin/settings/selectors.js 11 additions, 0 deletionsfrontend/src/metabase/admin/settings/selectors.js
- frontend/src/metabase/query_builder/components/NativeQueryEditor.jsx 10 additions, 2 deletions...c/metabase/query_builder/components/NativeQueryEditor.jsx
- frontend/src/metabase/query_builder/containers/QueryBuilder.jsx 3 additions, 15 deletions...nd/src/metabase/query_builder/containers/QueryBuilder.jsx
- frontend/src/metabase/query_builder/selectors.js 24 additions, 0 deletionsfrontend/src/metabase/query_builder/selectors.js
- frontend/src/metabase/services.js 1 addition, 1 deletionfrontend/src/metabase/services.js
- frontend/test/metabase/scenarios/native/reproductions/20625-prefix-match.cy.spec.js 4 additions, 0 deletions...narios/native/reproductions/20625-prefix-match.cy.spec.js
- src/metabase/api/database.clj 28 additions, 4 deletionssrc/metabase/api/database.clj
- test/metabase/api/database_test.clj 6 additions, 6 deletionstest/metabase/api/database_test.clj
Loading
Please register or sign in to comment