Add drag and drop reordering of pinned items (#19966)
* onDrop unneeded * basic impl of reordering pinned items * split cards and dashboards again * Improve pin drop target styling * Fix card drop target weirdness * brand-light border --> brand * pull out separate styled drop target component * replace style prop usage * reduce the z-index * Remove prop that triggers drill functionality * Fix clobbering of pinned list on update * Fix card queries on every rerender * Add pin drop zone & split drop target components * lint fix * fix & add a few tests * update pin drop zone styling to match sorting
Showing
- frontend/src/metabase/collections/components/CollectionCardVisualization/CollectionCardVisualization.jsx 8 additions, 4 deletions...llectionCardVisualization/CollectionCardVisualization.jsx
- frontend/src/metabase/collections/components/CollectionCardVisualization/CollectionCardVisualization.styled.jsx 5 additions, 0 deletions...nCardVisualization/CollectionCardVisualization.styled.jsx
- frontend/src/metabase/collections/components/ItemsTable.jsx 9 additions, 26 deletionsfrontend/src/metabase/collections/components/ItemsTable.jsx
- frontend/src/metabase/collections/components/PinDropZone/PinDropZone.styled.tsx 42 additions, 0 deletions...collections/components/PinDropZone/PinDropZone.styled.tsx
- frontend/src/metabase/collections/components/PinDropZone/PinDropZone.tsx 30 additions, 0 deletions...tabase/collections/components/PinDropZone/PinDropZone.tsx
- frontend/src/metabase/collections/components/PinDropZone/index.ts 1 addition, 0 deletions.../src/metabase/collections/components/PinDropZone/index.ts
- frontend/src/metabase/collections/components/PinnedItemOverview/PinnedItemOverview.styled.tsx 5 additions, 2 deletions...mponents/PinnedItemOverview/PinnedItemOverview.styled.tsx
- frontend/src/metabase/collections/components/PinnedItemOverview/PinnedItemOverview.tsx 80 additions, 49 deletions...ions/components/PinnedItemOverview/PinnedItemOverview.tsx
- frontend/src/metabase/collections/components/PinnedItemOverview/PinnedItemOverview.unit.spec.js 34 additions, 6 deletions...onents/PinnedItemOverview/PinnedItemOverview.unit.spec.js
- frontend/src/metabase/collections/components/PinnedItemSortDropTarget/PinnedItemSortDropTarget.styled.tsx 50 additions, 0 deletions...nedItemSortDropTarget/PinnedItemSortDropTarget.styled.tsx
- frontend/src/metabase/collections/components/PinnedItemSortDropTarget/PinnedItemSortDropTarget.tsx 17 additions, 0 deletions...nts/PinnedItemSortDropTarget/PinnedItemSortDropTarget.tsx
- frontend/src/metabase/collections/components/PinnedItemSortDropTarget/index.ts 1 addition, 0 deletions.../collections/components/PinnedItemSortDropTarget/index.ts
- frontend/src/metabase/collections/containers/CollectionContent.jsx 8 additions, 11 deletions...src/metabase/collections/containers/CollectionContent.jsx
- frontend/src/metabase/containers/dnd/DropArea.jsx 4 additions, 1 deletionfrontend/src/metabase/containers/dnd/DropArea.jsx
- frontend/src/metabase/containers/dnd/ItemDragSource.jsx 1 addition, 1 deletionfrontend/src/metabase/containers/dnd/ItemDragSource.jsx
- frontend/src/metabase/containers/dnd/ItemsDragLayer.jsx 1 addition, 0 deletionsfrontend/src/metabase/containers/dnd/ItemsDragLayer.jsx
- frontend/src/metabase/containers/dnd/PinDropTarget.jsx 15 additions, 1 deletionfrontend/src/metabase/containers/dnd/PinDropTarget.jsx
- frontend/src/metabase/containers/dnd/PinnedItemSortDropTarget.jsx 56 additions, 0 deletions.../src/metabase/containers/dnd/PinnedItemSortDropTarget.jsx
- frontend/src/metabase/containers/dnd/index.js 1 addition, 0 deletionsfrontend/src/metabase/containers/dnd/index.js
Loading
Please register or sign in to comment