Clean collection items bulk selection when opening another collection (#21803)

* Reproduce #16491

* Clean bulk selection on collection change

frontend/src/metabase/collections/containers/CollectionContent.jsx

@@ -24,6 +24,7 @@ import PaginationControls from "metabase/components/PaginationControls";
 
 import { useOnMount } from "metabase/hooks/use-on-mount";
 import { usePagination } from "metabase/hooks/use-pagination";
+import { usePrevious } from "metabase/hooks/use-previous";
 import { useListSelect } from "metabase/hooks/use-list-select";
 import { isSmallScreen } from "metabase/lib/dom";
 import {
@@ -82,6 +83,7 @@ function CollectionContent({
     getIsSelected,
     clear,
   } = useListSelect(itemKeyFn);
+  const previousCollection = usePrevious(collection);
 
   useOnMount(() => {
     if (!isSmallScreen()) {
@@ -89,6 +91,12 @@ function CollectionContent({
     }
   });
 
+  useEffect(() => {
+    if (previousCollection && previousCollection.id !== collection.id) {
+      clear();
+    }
+  }, [previousCollection, collection, clear]);
+
   useEffect(() => {
     const shouldBeBookmarked = bookmarks.some(
       bookmark =>

frontend/test/metabase/scenarios/collections/collections.cy.spec.js

@@ -317,6 +317,20 @@ describe("scenarios > collection defaults", () => {
           bulkSelectDeselectWorkflow();
         });
 
+        it("should clean up selection when opening another collection (metabase#16491)", () => {
+          cy.request("PUT", "/api/card/1", {
+            collection_id: 1,
+          });
+          cy.visit("/collection/root");
+          cy.findByText("Your personal collection").click();
+
+          selectItemUsingCheckbox("Orders");
+          cy.findByText("1 item selected").should("be.visible");
+
+          cy.findByText("Our analytics").click();
+          cy.findByTestId("bulk-action-bar").should("not.be.visible");
+        });
+
         function bulkSelectDeselectWorkflow() {
           cy.visit("/collection/root");
           selectItemUsingCheckbox("Orders");