Skip to content
Snippets Groups Projects
Commit 677d1e08 authored by Cam Saul's avatar Cam Saul Committed by GitHub
Browse files

Revert "Fix MySQL 5.1 support"

parent 8402584e
Branches
Tags
No related merge requests found
#! /usr/bin/env perl
use strict;
use warnings;
my $long_remarks = 0;
# loop over every line in migrations file. If line starts with `remarks:` and is over 60 chars, inc count & log error
open(FILE, '<:encoding(UTF-8)', './resources/migrations/000_migrations.yaml') or die $!;
while (<FILE>) {
$long_remarks += 1 && print "Remark on line $. is too long (${\(length)}/60): $_"
if m/remarks/ && s/^\s+remarks:\s'(.*)'$/$1/ && length > 60;
}
# if we've seen any remarks that are too long print message and die
die "\n$long_remarks remarks are over 60 characters long, making them incompatible with MySQL 5.1.\n" if $long_remarks;
print 'All remarks are 60 characters or less. Good work.' . "\n";
......@@ -46,7 +46,6 @@ node-4() {
run_step ./bin/reflection-linter
}
node-5() {
run_step ./bin/check_for_long_migration_remarks.pl
run_step lein eastwood
run_step yarn run lint
run_step yarn run flow
......
......@@ -71,7 +71,7 @@ Start the frontend build process with
yarn run build-hot
Caveat - Yarn does not properly support `build-hot` on Windows 8/10. You will need to manually build the frontend client with
yarn run build
This will get you a full development server running on port :3000 by default.
......@@ -114,7 +114,7 @@ All frontend tests are located in `frontend/test` directory. Run all frontend te
./bin/build version uberjar && yarn run test
```
which will first build the backend JAR and then run integration, unit and Karma browser tests in sequence.
which will first build the backend JAR and then run integration, unit and Karma browser tests in sequence.
### Jest integration tests
Integration tests simulate realistic sequences of user interactions. They render a complete DOM tree using [Enzyme](http://airbnb.io/enzyme/docs/api/index.html) and use temporary backend instances for executing API calls.
......@@ -154,7 +154,7 @@ describe("Query builder", () => {
})
it("should let you run a new query", async () => {
// Create a superpowered Redux store.
// Create a superpowered Redux store.
// Remember `await` here!
const store = await createTestStore()
......@@ -194,7 +194,7 @@ You can also skim through [`__support__/integrated_tests.js`](https://github.com
### Jest unit tests
Unit tests are focused around isolated parts of business logic.
Unit tests are focused around isolated parts of business logic.
Unit tests use an enforced file naming convention `<test-suite-name>.unit.js` to separate them from integration tests.
......@@ -204,7 +204,7 @@ yarn run jest-test-watch # Watch for file changes
```
### Karma browser tests
If you need to test code which uses browser APIs that are only available in real browsers, you can add a Karma test to `frontend/test/legacy-karma` directory.
If you need to test code which uses browser APIs that are only available in real browsers, you can add a Karma test to `frontend/test/legacy-karma` directory.
```
yarn run test-karma # Run all tests once
......@@ -240,11 +240,7 @@ Due to some issues with the way we've structured our test setup code, you curren
##### Run the linters:
./bin/check_for_long_migration_remarks && \
lein eastwood && \
lein bikeshed && \
lein docstring-checker && \
./bin/reflection-linter
lein eastwood && lein bikeshed && lein docstring-checker && ./bin/reflection-linter
#### Developing with Emacs
......
This diff is collapsed.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment