Highlight Trash collection in sidebar when viewing root trash collection or a trashed item (#44258)
* highlights the trash link in the sidebar when viewing root trash collection or a trashed item * impls pr feedback * impls more pr feedback * fixes unit tests and logical mistake that allowed urls with invalid collection ids to match on undefined trash id due to it not being loaded yet
Showing
- e2e/test/scenarios/collections/trash.cy.spec.js 62 additions, 5 deletionse2e/test/scenarios/collections/trash.cy.spec.js
- frontend/src/metabase/collections/components/CollectionLanding/CollectionLanding.tsx 9 additions, 2 deletions...ctions/components/CollectionLanding/CollectionLanding.tsx
- frontend/src/metabase/nav/containers/MainNavbar/MainNavbar.tsx 21 additions, 2 deletions...end/src/metabase/nav/containers/MainNavbar/MainNavbar.tsx
- frontend/src/metabase/nav/containers/MainNavbar/MainNavbar.unit.spec.tsx 7 additions, 3 deletions...tabase/nav/containers/MainNavbar/MainNavbar.unit.spec.tsx
- frontend/src/metabase/nav/containers/MainNavbar/MainNavbarContainer/MainNavbarContainer.tsx 1 addition, 0 deletions...rs/MainNavbar/MainNavbarContainer/MainNavbarContainer.tsx
- frontend/src/metabase/nav/containers/MainNavbar/getSelectedItems.ts 31 additions, 2 deletions...rc/metabase/nav/containers/MainNavbar/getSelectedItems.ts
- frontend/test/__support__/server-mocks/collection.ts 1 addition, 0 deletionsfrontend/test/__support__/server-mocks/collection.ts
Loading
Please register or sign in to comment