Skip to content
Snippets Groups Projects
Commit 67eaf581 authored by Allen Gilliland's avatar Allen Gilliland
Browse files

Merge pull request #2003 from metabase/2d-multiseries-titles

Card title for 2D multiseries
parents 2d94eda1 00849277
No related branches found
No related tags found
No related merge requests found
......@@ -6,6 +6,7 @@ import ChartTooltip from "./ChartTooltip.jsx";
import { isNumeric, isDate, isDimension, isString } from "metabase/lib/schema_metadata";
import { isSameSeries } from "metabase/visualizations/lib/utils";
import Urls from "metabase/lib/urls";
import { MinColumnsError, MinRowsError } from "metabase/visualizations/lib/errors";
......@@ -86,7 +87,7 @@ export default class LineAreaBarChart extends Component {
(p, v) => p.concat([[...v.slice(0, dimensionIndex), ...v.slice(dimensionIndex+1)]]),
(p, v) => null, () => []
).all().map(o => ({
card: { ...s.card, name: o.key },
card: { ...s.card, name: o.key, id: null },
data: {
rows: o.value,
cols: [...s.data.cols.slice(0,dimensionIndex), ...s.data.cols.slice(dimensionIndex+1)]
......@@ -119,12 +120,17 @@ export default class LineAreaBarChart extends Component {
let { hovered, isDashboard, onAddSeries, onRemoveSeries, extraActions, allowSplitAxis } = this.props;
let { series, isMultiseries } = this.state;
let card = this.props.series[0].card;
const chartType = this.constructor.identifier;
return (
<div className={cx("flex flex-column p1", this.getHoverClasses(), this.props.className)}>
{ (isDashboard && isMultiseries) &&
<a href={card.id && Urls.card(card.id)} className="Card-title pt1 px1 flex-no-shrink no-decoration h3 text-bold" style={{fontSize: '1em'}}>{card.name}</a>
}
{ (isDashboard || isMultiseries) &&
<LegendHeader
className="flex-no-shrink"
series={series}
onAddSeries={isMultiseries ? undefined : onAddSeries}
onRemoveSeries={onRemoveSeries}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment