Force slack channel cache refresh when new token is saved (#23253)

* clear Slack cache last-updated value when resetting cache

* use clear-channel-cache! function on invalid tokens as well

src/metabase/api/slack.clj

@@ -24,7 +24,7 @@
     (when (and slack-app-token
                (not config/is-test?)
                (not (slack/valid-token? slack-app-token)))
-      (slack/slack-cached-channels-and-usernames! [])
+      (slack/clear-channel-cache!)
       (throw (ex-info (tru "Invalid Slack token.")
                       {:errors {:slack-app-token (tru "invalid token")}})))
     (slack/slack-app-token! slack-app-token)
@@ -35,7 +35,7 @@
           ;; refresh user/conversation cache when token is newly valid
           (slack/refresh-channels-and-usernames-when-needed!))
       ;; clear user/conversation cache when token is newly empty
-      (slack/slack-cached-channels-and-usernames! []))
+      (slack/clear-channel-cache!))
     (let [processed-files-channel (slack/process-files-channel-name slack-files-channel)]
       (when (and processed-files-channel (not (slack/channel-exists? processed-files-channel)))
         (throw (ex-info (tru "Slack channel not found.")

src/metabase/integrations/slack.clj

@@ -219,6 +219,12 @@
    (slack-channels-and-usernames-last-updated)
    (t/minutes 10)))
 
+(defn clear-channel-cache!
+  "Clear the Slack channels cache, and reset its last-updated timestamp to its default value (the Unix epoch)."
+  []
+  (slack-channels-and-usernames-last-updated! zoned-time-epoch)
+  (slack-cached-channels-and-usernames! []))
+
 (defn refresh-channels-and-usernames!
   "Refreshes users and conversations in slack-cache. finds both in parallel, sets
   [[slack-cached-channels-and-usernames]], and resets the [[slack-channels-and-usernames-last-updated]] time."

test/metabase/api/slack_test.clj

 (ns metabase.api.slack-test
   (:require [clojure.string :as str]
             [clojure.test :refer :all]
+            [java-time :as t]
             [metabase.config :as config]
             [metabase.integrations.slack :as slack]
             [metabase.test :as mt]))
@@ -50,11 +51,17 @@
 
     (testing "The Slack app token or files channel settings are cleared if no value is sent in the request"
       (mt/with-temporary-setting-values [slack-app-token "fake-token"
-                                         slack-files-channel "fake-channel"]
+                                         slack-files-channel "fake-channel"
+                                         slack/slack-cached-channels-and-usernames ["fake_channel"]
+                                         slack/slack-channels-and-usernames-last-updated (t/zoned-date-time)]
         (mt/user-http-request :crowberto :put 200 "slack/settings" {})
         (is (= nil (slack/slack-app-token)))
         ;; The files channel is reset to its default value
-        (is (= "metabase_files" (slack/slack-files-channel)))))
+        (is (= "metabase_files" (slack/slack-files-channel)))
+        ;; The cache is empty, and its last-updated value is reset to its default value
+        (is (= [] (slack/slack-cached-channels-and-usernames)))
+        (is (= @#'slack/zoned-time-epoch (slack/slack-channels-and-usernames-last-updated)))))
+
 
     (testing "A non-admin cannot modify the Slack app token or files channel settings"
       (mt/user-http-request :rasta :put 403 "slack/settings"

test/metabase/integrations/slack_test.clj

@@ -137,8 +137,8 @@
     (testing "should be able to fetch list of users and page"
       (http-fake/with-fake-routes {users-endpoint (comp mock-200-response mock-users-response-body)}
         (let [expected-result (map
-                              (comp #(str \@ %) :name)
-                              (concat (mock-users) (mock-users)))]
+                               (comp #(str \@ %) :name)
+                               (concat (mock-users) (mock-users)))]
           (tu/with-temporary-setting-values [slack-token     nil
                                              slack-app-token "test-token"]
             (is (= expected-result