Fix action parameter types not saving correctly (#undefined)

e2e/test/scenarios/actions/actions-on-dashboards.cy.spec.js

 import { assocIn } from "icepick";
-import _ from "underscore";
 import {
   restore,
   queryWritableDB,
@@ -916,20 +915,28 @@ const MODEL_NAME = "Test Action Model";
           });
 
           actionEditorModal().within(() => {
-            cy.findByTestId("native-query-editor").click();
-
-            cy.get(".ace_content").type(
-              _.times(23, () => "{leftArrow}")
-                .join("")
-                .concat("{backspace}{backspace}"),
-            );
-            cy.get(".ace_text-input").type(`{{ score }}`, {
-              force: true,
+            cy.get(".ace_content").click().type("{home}{shift+end}{backspace}");
+            const TEST_COLUMNS_QUERY = `UPDATE ${TEST_COLUMNS_TABLE} SET timestamp = {{ Timestamp }} WHERE id = {{ ID }}`;
+            cy.get(".ace_content").type(TEST_COLUMNS_QUERY, {
+              delay: 0,
               parseSpecialCharSequences: false,
             });
 
             cy.findByTestId("action-form-editor").within(() => {
-              cy.findAllByText("Number").click({ multiple: true });
+              cy.contains("ID")
+                .closest('[data-testid="form-field-container"]')
+                .within(() => {
+                  cy.findByRole("radiogroup", { name: "Field type" })
+                    .findByText("Number")
+                    .click();
+                });
+              cy.contains("Timestamp")
+                .closest('[data-testid="form-field-container"]')
+                .within(() => {
+                  cy.findByRole("radiogroup", { name: "Field type" })
+                    .findByText("Date")
+                    .click();
+                });
             });
           });
 
@@ -938,8 +945,8 @@ const MODEL_NAME = "Test Action Model";
           });
 
           getActionParametersInputModal().within(() => {
-            cy.findByLabelText("Total").type(`123`);
-            cy.findByLabelText("Score").type(`345`);
+            cy.findByLabelText("Timestamp").type(`2020-01-01`);
+            cy.findByLabelText("ID").type(`1`);
 
             cy.button(SAMPLE_QUERY_ACTION.name).click();
           });
@@ -949,11 +956,13 @@ const MODEL_NAME = "Test Action Model";
               Object.values(interception.request.body.parameters)
                 .sort()
                 .join(","),
-            ).to.equal("123,345");
+            ).to.equal("1,2020-01-01");
           });
 
           cy.findByTestId("toast-undo").within(() => {
-            cy.findByText(`Success! The action returned: {"rows-affected":0}`);
+            cy.findByText(
+              `${SAMPLE_WRITABLE_QUERY_ACTION.name} ran successfully`,
+            ).should("be.visible");
           });
         });
       });

frontend/src/metabase/actions/containers/ActionCreator/ActionContext/QueryActionContextProvider/QueryActionContextProvider.tsx

@@ -103,7 +103,7 @@ function convertQuestionToAction(
     id: question.id(),
     name: question.displayName() as string,
     description: question.description(),
-    dataset_query: question.datasetQuery() as NativeDatasetQuery,
+    dataset_query: cleanQuestion.datasetQuery() as NativeDatasetQuery,
     database_id: question.databaseId() as DatabaseId,
     parameters: parameters as WritebackParameter[],
     visualization_settings: formSettings,