-
- Downloads
Fix no warning when leaving edited native questions (#31986)
* Add warning message when leaving an edited, existing SQL question This PR adds this functionality that's supposed be a part of an epic https://github.com/metabase/metabase/issues/29421 * Use similar structure on other part that rely on the same logic * Fix condition to show browser prompt + add tests * Prevent passing new props to QueryBuilder Since those props will be pass down to other children, and they won't be used anyway. Those new props are only used in this file. * Make test setup more concise * Address review: Change from util function to selector * Address review: move hook to sector and move selector tests to component test * Fix failed unit tests from merging `master`
Showing
- frontend/src/metabase/containers/SaveQuestionModal.tsx 5 additions, 3 deletionsfrontend/src/metabase/containers/SaveQuestionModal.tsx
- frontend/src/metabase/containers/SaveQuestionModal.unit.spec.tsx 12 additions, 3 deletions...d/src/metabase/containers/SaveQuestionModal.unit.spec.tsx
- frontend/src/metabase/query_builder/containers/QueryBuilder.jsx 5 additions, 15 deletions...nd/src/metabase/query_builder/containers/QueryBuilder.jsx
- frontend/src/metabase/query_builder/containers/QueryBuilder.unit.spec.tsx 116 additions, 11 deletions...abase/query_builder/containers/QueryBuilder.unit.spec.tsx
- frontend/src/metabase/query_builder/selectors.js 42 additions, 2 deletionsfrontend/src/metabase/query_builder/selectors.js
- frontend/src/metabase/query_builder/utils.ts 21 additions, 3 deletionsfrontend/src/metabase/query_builder/utils.ts
- frontend/src/metabase/selectors/app.ts 4 additions, 7 deletionsfrontend/src/metabase/selectors/app.ts
Loading
Please register or sign in to comment