Skip to content
Snippets Groups Projects
Unverified Commit 6a071da7 authored by Mahatthana (Kelvin) Nomsawadi's avatar Mahatthana (Kelvin) Nomsawadi Committed by GitHub
Browse files

Fix no warning when leaving edited native questions (#31986)

* Add warning message when leaving an edited, existing SQL question

This PR adds this functionality that's supposed be a part of
an epic https://github.com/metabase/metabase/issues/29421

* Use similar structure on other part that rely on the same logic

* Fix condition to show browser prompt + add tests

* Prevent passing new props to QueryBuilder

Since those props will be pass down to other children, and they won't be
used anyway. Those new props are only used in this file.

* Make test setup more concise

* Address review: Change from util function to selector

* Address review: move hook to sector and move selector tests to component test

* Fix failed unit tests from merging `master`
parent c436cee5
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment