Misc settings tweaks

frontend/src/metabase/admin/settings/components/widgets/FormattingWidget.jsx

@@ -12,7 +12,7 @@ const SETTING_TYPES = [
       "date_style",
       "date_separator",
       "date_abbreviate",
-      "time_enabled",
+      // "time_enabled",
       "time_style",
     ],
     column: {

frontend/src/metabase/visualizations/components/ColumnSettings.jsx

@@ -43,7 +43,7 @@ const ColumnSettings = ({
 
   // add a "unit" to make certain settings work
   if (column.unit == null) {
-    column = { ...column, unit: "millisecond" };
+    column = { ...column, unit: "default" };
   }
 
   // $FlowFixMe

frontend/src/metabase/visualizations/components/TableInteractive.jsx

@@ -448,7 +448,7 @@ export default class TableInteractive extends Component {
     const column = cols[columnIndex];
 
     let columnTitle =
-      settings.column(column)._column_title_full || formatColumn(column);
+      settings.column(column)["_column_title_full"] || formatColumn(column);
 
     if (!columnTitle && this.props.isPivoted && columnIndex !== 0) {
       columnTitle = t`Unset`;

frontend/src/metabase/visualizations/components/TableSimple.jsx

@@ -154,7 +154,7 @@ export default class TableSimple extends Component {
                           }}
                         />
                         <Ellipsified>
-                          {settings.column(col)._column_title_full ||
+                          {settings.column(col)["_column_title_full"] ||
                             formatColumn(col)}
                         </Ellipsified>
                       </div>

frontend/src/metabase/visualizations/lib/settings/column.js

@@ -228,10 +228,15 @@ export const DATE_COLUMN_SETTINGS = {
         { name: t`Off`, value: null },
         { name: t`HH:MM`, value: "minutes" },
       ];
-      if (!unit || unit === "default" || unit === "second") {
+      if (
+        !unit ||
+        unit === "default" ||
+        unit === "second" ||
+        unit === "millisecond"
+      ) {
         options.push({ name: t`HH:MM:SS`, value: "seconds" });
       }
-      if (!unit || unit === "default") {
+      if (!unit || unit === "default" || unit === "millisecond") {
         options.push({ name: t`HH:MM:SS.MS`, value: "milliseconds" });
       }
       if (options.length === 2) {