Fix flaky homepage xrays test (#49765) (#49862)

* Fix flaky test

* Add a comment

Co-authored-by: Kamil Mielnik <kamil@kamilmielnik.com>

e2e/test/scenarios/onboarding/home/homepage.cy.spec.js

@@ -100,6 +100,12 @@ describe("scenarios > home > homepage", () => {
 
       cy.visit("/");
       cy.wait("@getXrayCandidates");
+      // The repeated assertion below uses { timeout: 0 } and sometimes it happens too fast,
+      // even before React finishes re-rendering after @getXrayCandidates completes.
+      // This assertion prevents it.
+      cy.findByTestId("home-page")
+        .findByTestId("loading-indicator")
+        .should("not.exist");
 
       repeatAssertion(() =>
         cy