Skip to content
Snippets Groups Projects
Unverified Commit 6ce6e76d authored by Alexander Polyankin's avatar Alexander Polyankin Committed by GitHub
Browse files

Fix column duplication when adding a new breakout (#24503)

parent 6308bc77
No related branches found
No related tags found
No related merge requests found
......@@ -660,8 +660,9 @@ class QuestionInner {
query.columnNames(),
);
const graphMetrics = this.setting("graph.metrics");
if (
this.setting("graph.metrics") &&
graphMetrics &&
addedColumnNames.length > 0 &&
removedColumnNames.length === 0
) {
......@@ -672,22 +673,22 @@ class QuestionInner {
if (addedMetricColumnNames.length > 0) {
return this.updateSettings({
"graph.metrics": [
...this.setting("graph.metrics"),
...addedMetricColumnNames,
],
"graph.metrics": [...graphMetrics, ...addedMetricColumnNames],
});
}
}
const tableColumns = this.setting("table.columns");
if (
this.setting("table.columns") &&
tableColumns &&
addedColumnNames.length > 0 &&
removedColumnNames.length === 0
) {
return this.updateSettings({
"table.columns": [
...this.setting("table.columns"),
...tableColumns.filter(
column => !addedColumnNames.includes(column.name),
),
...addedColumnNames.map(name => {
const dimension = query.columnDimensionWithName(name);
return {
......
......@@ -188,7 +188,7 @@ describe("binning related reproductions", () => {
cy.findByText("Hour of Day");
});
it.skip("shouldn't duplicate the breakout field (metabase#22382)", () => {
it("shouldn't duplicate the breakout field (metabase#22382)", () => {
const questionDetails = {
name: "22382",
query: {
......@@ -206,7 +206,7 @@ describe("binning related reproductions", () => {
cy.findByTestId("sidebar-left").within(() => {
cy.findByTextEnsureVisible("Table options");
cy.findByText("Count").siblings(".Icon-close").click();
cy.findByText("Created At").siblings(".Icon-close").click();
cy.button("Done").click();
});
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment