Skip to content
Snippets Groups Projects
Unverified Commit 6df84eb5 authored by Maz Ameli's avatar Maz Ameli Committed by GitHub
Browse files

Tag untagged strings (#10463)

* replace accordian with accordion everywhere (#10449)

* a game of tag tagging untagged strings
parent ee4f9863
No related branches found
No related tags found
No related merge requests found
/* @flow */
import { MBQLObjectClause } from "./MBQLClause";
import { t } from "ttag";
import StructuredQuery from "../StructuredQuery";
import Dimension, { JoinedDimension } from "metabase-lib/lib/Dimension";
......@@ -18,10 +19,10 @@ import type {
import _ from "underscore";
const JOIN_STRATEGY_OPTIONS = [
{ value: "left-join", name: "Left outer join", icon: "join_left_outer" }, // default
{ value: "right-join", name: "Right outer join", icon: "join_right_outer" },
{ value: "inner-join", name: "Inner join", icon: "join_inner" },
{ value: "full-join", name: "Full outer join", icon: "join_full_outer" },
{ value: "left-join", name: t`Left outer join`, icon: "join_left_outer" }, // default
{ value: "right-join", name: t`Right outer join`, icon: "join_right_outer" },
{ value: "inner-join", name: t`Inner join`, icon: "join_inner" },
{ value: "full-join", name: t`Full outer join`, icon: "join_full_outer" },
];
export default class Join extends MBQLObjectClause {
......
......@@ -241,7 +241,7 @@ function BrowseHeader({ crumbs }) {
<div className="flex align-center text-medium text-brand-hover">
<Icon className="flex align-center" size={14} name="reference" />
<Link className="ml1 flex align-center text-bold">
Learn about our data
{t`Learn about our data`}
</Link>
</div>
</Link>
......
......@@ -47,6 +47,7 @@ const BASE_FORM_FIELDS: FormFieldDefinition[] = [
},
{
name: "email",
title: t`Email`,
placeholder: "youlooknicetoday@email.com",
validate: email => !email && t`Email is required`,
},
......
......@@ -3,6 +3,7 @@ import React from "react";
import { Flex } from "grid-styled";
import cx from "classnames";
import _ from "underscore";
import { t } from "ttag";
import {
NotebookCell,
......@@ -146,7 +147,7 @@ class JoinClause extends React.Component {
icon="table2"
inactive={!joinedTable}
>
{joinedTable ? joinedTable.displayName() : `Pick a table...`}
{joinedTable ? joinedTable.displayName() : t`Pick a table...`}
</NotebookCellItem>
}
/>
......
import React from "react";
import { t } from "ttag";
import Input from "metabase/components/Input";
import { NotebookCell } from "../NotebookCell";
......@@ -18,7 +20,7 @@ export default function LimitStep({
className="mb1"
type="number"
value={query.limit() == null ? "" : query.limit()}
placeholder="Enter a limit"
placeholder={t`Enter a limit`}
onChange={e => {
const limit = parseInt(e.target.value, 0);
if (limit >= 1) {
......
......@@ -61,7 +61,7 @@ export default function QuestionFilters({
))}
</div>
) : (
<Tooltip tooltip={`Show filters`}>
<Tooltip tooltip={t`Show filters`}>
<FilterPill invert icon="filter" onClick={onExpand}>
{filters.length}
</FilterPill>
......
......@@ -80,7 +80,7 @@ export default class SummarizeSidebar extends React.Component {
</div>
{query.hasAggregations() && (
<div className="border-top mt3 pt3 mx1">
<h3 className="text-heavy mb2 ml2">Group by</h3>
<h3 className="text-heavy mb2 ml2">{t`Group by`}</h3>
<SummarizeBreakouts className="mx2" query={query} />
</div>
)}
......@@ -164,7 +164,7 @@ const SummarizeAggregationAdd = ({ className, query }) => {
className="flex-full align-center rounded bg-light bg-medium-hover text-green text-bold transition-all"
>
<Icon className="ml2 mr1" name="add" size="10" />
<span className="text-small">Add a metric</span>
<span className="text-small">{t`Add a metric`}</span>
</Flex>
}
isInitiallyOpen={!query.hasAggregations()}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment