recents updates to better support metrics (#47032)

* recents updates to better support metrics

allows updating metric views through the API
improves parent_collection calculation

* add 2 tests for metrics

src/metabase/models/recent_views.clj

@@ -80,8 +80,9 @@
 
 (def rv-models
   "These are models for which we will retrieve recency."
-  [:card :dataset ;; n.b.: `:card` and `:model` are stored in recent_views as "card", and a join with report_card is
-                  ;; needed to distinguish between them.
+  [:card :dataset :metric
+   ;; n.b.: `:card`, `metric` and `:model` are stored in recent_views as "card", and a join with report_card is
+   ;; needed to distinguish between them.
    :dashboard :table :collection])
 
 (mu/defn rv-model->model
@@ -318,11 +319,7 @@
      :can_write (mi/can-write? metric)
      :timestamp (str timestamp)
      :moderated_status (:moderated-status metric)
-     :parent_collection (if (:collection-id metric)
-                          {:id (:collection-id metric)
-                           :name (:collection-name metric)
-                           :authority_level (:collection-authority-level metric)}
-                          (root-coll))}))
+     :parent_collection (fill-parent-coll metric)}))
 
 ;; ================== Recent Dashboards ==================
 

test/metabase/models/recent_views_test.clj

@@ -70,6 +70,25 @@
              (mapv fixup
                    (recent-views (mt/user->id :rasta))))))))
 
+(deftest simple-get-list-metric-test
+  (mt/with-temp
+    [:model/Collection {coll-id :id} {:name "my coll"}
+     :model/Database   {db-id :id}   {}
+     :model/Card       {card-id         :id} {:type "metric" :name "name" :display "display" :collection_id coll-id :database_id db-id}]
+    (recent-views/update-users-recent-views! (mt/user->id :rasta) :model/Card card-id :view)
+    (is (= [{:description nil,
+             :can_write true,
+             :name "name",
+             :parent_collection {:id coll-id, :name "my coll", :authority_level nil},
+             :moderated_status nil,
+             :id card-id,
+             :display "display",
+             :timestamp java.lang.String,
+             :model :metric}]
+           (mt/with-test-user :rasta
+             (mapv fixup
+                   (recent-views (mt/user->id :rasta))))))))
+
 (deftest simple-get-list-dashboard-test
   (mt/with-temp
     [:model/Collection {coll-id :id} {:name "my coll"}
@@ -181,11 +200,13 @@
 
            :model/Card       {card-id :id} {:type "question" :name "my card" :description "this is my card" :collection_id parent-coll-id :database_id db-id}
            :model/Card       {model-id :id} {:type "model" :name "my model" :description "this is my model" :collection_id parent-coll-id :database_id db-id}
+           :model/Card       {metric-id :id} {:type "metric" :name "my metric" :display "Metric" :collection_id parent-coll-id :database_id db-id}
            :model/Dashboard  {dashboard-id :id} {:name "my dash" :description "this is my dash" :collection_id parent-coll-id}
            :model/Collection {collection-id :id} {:name "my collection" :description "this is my collection" :location (->location parent-coll-id)}
            :model/Table      {table-id :id} {:name "tablet" :display_name "I am the table" :db_id db-id, :is_upload true}]
           (doseq [[model model-id] [[:model/Card card-id]
                                     [:model/Card model-id]
+                                    [:model/Card metric-id]
                                     [:model/Dashboard dashboard-id]
                                     [:model/Collection collection-id]
                                     [:model/Table table-id]]]
@@ -211,6 +232,14 @@
                    :model :dashboard,
                    :can_write true,
                    :parent_collection {:id "ID", :name "parent", :authority_level nil}}
+                  {:description nil,
+                   :can_write true,
+                   :name "my metric",
+                   :parent_collection {:id "ID", :name "parent", :authority_level nil},
+                   :moderated_status nil,
+                   :id "ID",
+                   :display "Metric",
+                   :model :metric}
                   {:id "ID",
                    :name "my model",
                    :description "this is my model",