Skip to content
Snippets Groups Projects
Commit 6f27913b authored by Allen Gilliland's avatar Allen Gilliland
Browse files

instrumentation of a few changes to QB flow with new saving semantics.

parent 95e8e75e
Branches
Tags
No related merge requests found
......@@ -133,14 +133,17 @@ CardControllers.controller('CardDetail', [
onBeginEditing: function() {
isEditing = true;
renderAll();
MetabaseAnalytics.trackEvent('QueryBuilder', 'Edit Begin');
},
onCancelEditing: function() {
// reset back to our original card
isEditing = false;
setCard(originalCard, {resetDirty: true});
MetabaseAnalytics.trackEvent('QueryBuilder', 'Edit Cancel');
},
onRestoreOriginalQuery: function () {
setCard(originalCard, {resetDirty: true});
MetabaseAnalytics.trackEvent('QueryBuilder', 'Restore Original');
},
cardIsNewFn: cardIsNew,
cardIsDirtyFn: cardIsDirty
......
......@@ -13,6 +13,7 @@ import QueryModeToggle from './QueryModeToggle.jsx';
import QuestionSavedModal from 'metabase/components/QuestionSavedModal.jsx';
import SaveQuestionModal from 'metabase/components/SaveQuestionModal.jsx';
import MetabaseAnalytics from "metabase/lib/analytics";
import Query from "metabase/lib/query";
import cx from "classnames";
......@@ -101,6 +102,7 @@ export default React.createClass({
onDelete: async function () {
await this.props.cardApi.delete({ 'cardId': this.props.card.id }).$promise;
this.onGoBack();
MetabaseAnalytics.trackEvent("QueryBuilder", "Delete");
},
onFollowBreadcrumb: function() {
......@@ -233,7 +235,7 @@ export default React.createClass({
if (!this.props.cardIsNewFn() && !this.props.isEditing) {
// simply adding an existing saved card to a dashboard, so show the modal to do so
buttonSections.push([
<span className="cursor-pointer text-brand-hover" onClick={() => this.setState({ modal: "add-to-dashboard" })}>
<span data-metabase-event={"QueryBuilder;AddToDash Modal;normal"} className="cursor-pointer text-brand-hover" onClick={() => this.setState({ modal: "add-to-dashboard" })}>
<Icon name="addtodash" width="16px" height="16px" />
</span>
]);
......@@ -244,7 +246,7 @@ export default React.createClass({
key="addtodashsave"
ref="addToDashSaveModal"
triggerClasses="h4 px1 text-grey-4 text-brand-hover text-uppercase"
triggerElement={<span className="text-brand-hover"><Icon name="addtodash" width="16px" height="16px" /></span>}
triggerElement={<span data-metabase-event={"QueryBuilder;AddToDash Modal;pre-save"} className="text-brand-hover"><Icon name="addtodash" width="16px" height="16px" /></span>}
>
<SaveQuestionModal
card={this.props.card}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment