Add `right` prop to NotebookCellItem (#17435)
* Remove not displayed NotebookCell's 'icon` prop * Refactor NotebookCell to accent `right` prop * Fix cypress getter * Fix icons opacity * Fix margins and paddings * Pass initialState to getStore test helper * Add basic tests for JoinStep * Test automatic join fields assignment * Add selectTable test helper * Fix private property access * Add join fields tests * Test join is correctly applied to query * Add more tests for join dimension pickers * Test selecting joined table columns * Disable failing JoinStep test (jest timeout) * Extend timeout for JoinStep tests
Showing
- frontend/src/metabase/query_builder/components/DataSelector.jsx 4 additions, 1 deletion...nd/src/metabase/query_builder/components/DataSelector.jsx
- frontend/src/metabase/query_builder/components/notebook/NotebookCell.jsx 82 additions, 34 deletions...tabase/query_builder/components/notebook/NotebookCell.jsx
- frontend/src/metabase/query_builder/components/notebook/steps/DataStep.jsx 2 additions, 6 deletions...base/query_builder/components/notebook/steps/DataStep.jsx
- frontend/src/metabase/query_builder/components/notebook/steps/JoinStep.jsx 9 additions, 4 deletions...base/query_builder/components/notebook/steps/JoinStep.jsx
- frontend/src/metabase/query_builder/components/notebook/steps/JoinStep.styled.js 9 additions, 4 deletions...uery_builder/components/notebook/steps/JoinStep.styled.js
- frontend/src/metabase/query_builder/components/notebook/steps/JoinStep.unit.spec.js 287 additions, 0 deletions...y_builder/components/notebook/steps/JoinStep.unit.spec.js
- frontend/src/metabase/reference/databases/FieldList.jsx 2 additions, 0 deletionsfrontend/src/metabase/reference/databases/FieldList.jsx
- frontend/test/__support__/entities-store.js 1 addition, 3 deletionsfrontend/test/__support__/entities-store.js
- frontend/test/metabase/scenarios/question/new.cy.spec.js 1 addition, 1 deletionfrontend/test/metabase/scenarios/question/new.cy.spec.js
Loading
Please register or sign in to comment