-
- Downloads
Separate SMTP Connection Setup from Other Email Settings (#35177)
* separate SMTP connection settings from other email settings * update tests based on now setup flow - some tests were removed as the behaviors of the app have changed - some tests were updated to validate the new SMTP connection card and setup process * improve tests * replace styled component with mantine flex * fix type errors * refactor breadcrumbs to use native solution in SettingsBatchForm * only show breadcrumbs if email is already configured * catch and handle error if form submission fails * fix tests * remove dead code * fix test failure and consolidate similar E2E tests * update unit tests to account for new behavior * fix type error - remove unused dispatch prop * update unit tests to account for redirect behavior * move dispatch to useEffect and convert file to typescript * fix button state on save error * add unit tests for hiding SMTP configuration when cloud-hosted
Showing
- e2e/test/scenarios/admin/settings/email.cy.spec.js 63 additions, 68 deletionse2e/test/scenarios/admin/settings/email.cy.spec.js
- frontend/src/metabase/admin/settings/app/components/SettingsEditor/SettingsSection.tsx 1 addition, 1 deletion...ettings/app/components/SettingsEditor/SettingsSection.tsx
- frontend/src/metabase/admin/settings/app/components/SettingsEditor/tests/allowed-domains.unit.spec.tsx 2 additions, 0 deletions...onents/SettingsEditor/tests/allowed-domains.unit.spec.tsx
- frontend/src/metabase/admin/settings/app/components/SettingsEditor/tests/common.unit.spec.tsx 30 additions, 2 deletions.../app/components/SettingsEditor/tests/common.unit.spec.tsx
- frontend/src/metabase/admin/settings/app/components/SettingsEditor/tests/enterprise.unit.spec.tsx 50 additions, 2 deletions.../components/SettingsEditor/tests/enterprise.unit.spec.tsx
- frontend/src/metabase/admin/settings/app/components/SettingsEditor/tests/user-visibility.unit.spec.tsx 5 additions, 1 deletion...onents/SettingsEditor/tests/user-visibility.unit.spec.tsx
- frontend/src/metabase/admin/settings/components/Email/SMTPConnectionCard.tsx 30 additions, 0 deletions...se/admin/settings/components/Email/SMTPConnectionCard.tsx
- frontend/src/metabase/admin/settings/components/Email/SMTPConnectionForm.tsx 164 additions, 0 deletions...se/admin/settings/components/Email/SMTPConnectionForm.tsx
- frontend/src/metabase/admin/settings/components/Email/SettingsEmailForm.tsx 57 additions, 0 deletions...ase/admin/settings/components/Email/SettingsEmailForm.tsx
- frontend/src/metabase/admin/settings/components/SettingsBatchForm.jsx 6 additions, 7 deletions.../metabase/admin/settings/components/SettingsBatchForm.jsx
- frontend/src/metabase/admin/settings/components/SettingsEmailForm.jsx 0 additions, 176 deletions.../metabase/admin/settings/components/SettingsEmailForm.jsx
- frontend/src/metabase/admin/settings/components/SettingsEmailForm.styled.tsx 0 additions, 6 deletions...se/admin/settings/components/SettingsEmailForm.styled.tsx
- frontend/src/metabase/admin/settings/selectors.js 46 additions, 39 deletionsfrontend/src/metabase/admin/settings/selectors.js
- frontend/src/metabase/components/Breadcrumbs/Breadcrumbs.jsx 4 additions, 1 deletionfrontend/src/metabase/components/Breadcrumbs/Breadcrumbs.jsx
Loading
Please register or sign in to comment