Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
71b74907
Unverified
Commit
71b74907
authored
1 year ago
by
Nemanja Glumac
Committed by
GitHub
1 year ago
Browse files
Options
Downloads
Patches
Plain Diff
[E2E] Fix public dashboard flake (#32343)
* Fix `public-dashboard` E2E flake Closes #32334.
parent
e8f666f5
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
e2e/test/scenarios/sharing/public-dashboard.cy.spec.js
+17
-8
17 additions, 8 deletions
e2e/test/scenarios/sharing/public-dashboard.cy.spec.js
with
17 additions
and
8 deletions
e2e/test/scenarios/sharing/public-dashboard.cy.spec.js
+
17
−
8
View file @
71b74907
...
...
@@ -102,14 +102,23 @@ describe("scenarios > public > dashboard", () => {
.
findByRole
(
"
switch
"
)
.
check
();
cy
.
wait
(
"
@publicLink
"
);
cy
.
findByRole
(
"
heading
"
,
{
name
:
"
Public link
"
})
.
parent
()
.
findByDisplayValue
(
/^http/
)
.
then
(
$input
=>
{
expect
(
$input
.
val
()).
to
.
match
(
PUBLIC_DASHBOARD_REGEX
);
});
cy
.
wait
(
"
@publicLink
"
).
then
(({
response
})
=>
{
expect
(
response
.
body
.
uuid
).
not
.
to
.
be
.
null
;
cy
.
findByRole
(
"
heading
"
,
{
name
:
"
Public link
"
})
// This click doesn't have any meaning in the context of the correctness of this test!
// It's simply here to prevent test flakiness, which happens because the Modal overlay
// is animating (disappearing) and we need to wait for it to stop the transition.
// Cypress will retry clicking this text until the DOM element is "actionable", or in
// our case - until there's no element on top of it blocking it. That's also when we
// expect this input field to be populated with the actual value.
.
click
()
.
parent
()
.
findByDisplayValue
(
/^http/
)
.
then
(
$input
=>
{
expect
(
$input
.
val
()).
to
.
match
(
PUBLIC_DASHBOARD_REGEX
);
});
});
});
Object
.
entries
(
USERS
).
map
(([
userType
,
setUser
])
=>
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment