Skip to content
Snippets Groups Projects
Unverified Commit 71fdba7e authored by Kamil Mielnik's avatar Kamil Mielnik Committed by GitHub
Browse files

User friendly error message when combining series that cannot be visualized together (#33119)

* Use named import for ErrorView

* Export ErrorView and ErrorViewProps from Visualization

* Define AddSeriesModalErrorView

* Make ErrorView component configurable in Visualization by introducing errorView prop

* Use AddSeriesModalErrorView thanks to new errorView prop

* Fix export type syntax

* Remove the dot for consistency with other error messages

* Rename AddSeriesModalErrorView to ErrorView and extract it to a separate file

* Allow translating the custom error message

* Don't show custom ErrorView when there is only one series (or none)

* Add a test case for a single incomplete chart

* Inline: dashcardData

* Add a reproduction e2e test for #32231

* Add explicit assertion for the error message

* Add a test case for default error message when there is only 1 series

* Remove redundant setup functions

* Wait for series query endpoint

* Rename ErrorView to VisualizationErrorView

* Rename VisualizationErrorView to MultipleSeriesErrorView

* Improve assertions

* Use editDashboard helper

* Use data-testid for AddSeriesModal

* Refactor errorView prop into errorMessageOverride
- Do not export ErrorViewProps and Error out of Visualization
parent f9a8b663
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment