User friendly error message when combining series that cannot be visualized together (#33119)
* Use named import for ErrorView * Export ErrorView and ErrorViewProps from Visualization * Define AddSeriesModalErrorView * Make ErrorView component configurable in Visualization by introducing errorView prop * Use AddSeriesModalErrorView thanks to new errorView prop * Fix export type syntax * Remove the dot for consistency with other error messages * Rename AddSeriesModalErrorView to ErrorView and extract it to a separate file * Allow translating the custom error message * Don't show custom ErrorView when there is only one series (or none) * Add a test case for a single incomplete chart * Inline: dashcardData * Add a reproduction e2e test for #32231 * Add explicit assertion for the error message * Add a test case for default error message when there is only 1 series * Remove redundant setup functions * Wait for series query endpoint * Rename ErrorView to VisualizationErrorView * Rename VisualizationErrorView to MultipleSeriesErrorView * Improve assertions * Use editDashboard helper * Use data-testid for AddSeriesModal * Refactor errorView prop into errorMessageOverride - Do not export ErrorViewProps and Error out of Visualization
Showing
- e2e/test/scenarios/dashboard-cards/reproductions/32231-add-incompatible-series.cy.spec.js 125 additions, 0 deletions...ds/reproductions/32231-add-incompatible-series.cy.spec.js
- frontend/src/metabase/dashboard/components/AddSeriesModal/AddSeriesModal.tsx 5 additions, 0 deletions...se/dashboard/components/AddSeriesModal/AddSeriesModal.tsx
- frontend/src/metabase/dashboard/components/AddSeriesModal/AddSeriesModal.unit.spec.tsx 38 additions, 9 deletions...rd/components/AddSeriesModal/AddSeriesModal.unit.spec.tsx
- frontend/src/metabase/dashboard/components/DashboardGrid.jsx 5 additions, 1 deletionfrontend/src/metabase/dashboard/components/DashboardGrid.jsx
- frontend/src/metabase/visualizations/components/Visualization/ErrorView/ErrorView.tsx 1 addition, 4 deletions...izations/components/Visualization/ErrorView/ErrorView.tsx
- frontend/src/metabase/visualizations/components/Visualization/ErrorView/index.ts 1 addition, 2 deletions...isualizations/components/Visualization/ErrorView/index.ts
- frontend/src/metabase/visualizations/components/Visualization/Visualization.jsx 4 additions, 2 deletions...visualizations/components/Visualization/Visualization.jsx
Loading
Please register or sign in to comment