Update and use consistent references to the issues in test reproductions (#13269)

* Apply new format to the issue references in tests and other "affected" files across the code base

* Add previously deleted issue references back to their test

frontend/src/metabase/components/Popover.css

@@ -11,7 +11,7 @@
   display: flex;
   flex-direction: column;
   /* add a max-width so that long strings don't cause the popover to expand
-   * see issue #4930 */
+   * see metabase#4930 */
   max-width: 500px;
 }
 
@@ -25,7 +25,7 @@
 
 /* remove the max-width in cases where the popover content needs to expand
  * initially added  for date pickers so the dual date picker can fully
- * expand as necessary - issue #5971
+ * expand as necessary - metabase#5971
  */
 .PopoverBody.PopoverBody--autoWidth {
   max-width: none;

frontend/src/metabase/css/core/inputs.css

@@ -51,7 +51,7 @@
   outline: 0;
 }
 
-/* prevent safari from forcing type="search" styles - issue #5225 */
+/* prevent safari from forcing type="search" styles - metabase#5225 */
 .input[type="search"] {
   -webkit-appearance: none;
 }

frontend/test/__support__/cypress.js

@@ -89,7 +89,7 @@ export function setupLocalHostEmail() {
   // Leaves password and username blank
   cy.findByPlaceholderText("metabase@yourcompany.com").type("test@local.host");
 
-  // *** Unnecessary click (Issue #12692)
+  // *** Unnecessary click (metabase#12692)
   cy.findByPlaceholderText("smtp.yourservice.com").click();
 
   cy.findByText("Save changes").click();

frontend/test/metabase-smoketest/admin.cy.spec.js

@@ -137,7 +137,7 @@ describe("metabase-smoketest > admin", () => {
         "Bar graph illustrating where our customers come from",
       );
 
-      // *** Cannot select 'My personal collection' (Issue #12718)
+      // *** Cannot select 'My personal collection' (metabase#12718)
       // cy.findByText("Our analytics").click();
       // cy.findByText("My personal collection").click();
       // cy.contains("My personal collection");
@@ -363,7 +363,7 @@ describe("metabase-smoketest > admin", () => {
         cy.findAllByText("Our analytics")
           .last()
           .click();
-        // *** Won't save into personal collection (Issue #12718)
+        // *** Won't save into personal collection (metabase#12718)
         // cy.findByText("My personal collection").click();
         cy.findAllByText("Save")
           .last()
@@ -383,7 +383,7 @@ describe("metabase-smoketest > admin", () => {
         cy.findAllByText("Our analytics")
           .last()
           .click();
-        // *** Won't save into personal collection (Issue #12718)
+        // *** Won't save into personal collection (metabase#12718)
         cy.findByText("Create").click();
 
         cy.findByText("This dashboard is looking empty.");

frontend/test/metabase-smoketest/admin_setup.cy.spec.js

@@ -147,7 +147,7 @@ describe("smoketest > admin_setup", () => {
 
       // Check member count
 
-      // *** Unnecessary click (Issue #12693)
+      // *** Unnecessary click (metabase#12693)
       cy.findAllByText("People")
         .last()
         .click();
@@ -190,7 +190,7 @@ describe("smoketest > admin_setup", () => {
       cy.findByText(new_user.first_name + " " + new_user.last_name);
       cy.findAllByText("2 other groups").should("have.length", 3);
 
-      // *** Unnecessary click (Issue #12693)
+      // *** Unnecessary click (metabase#12693)
       cy.findAllByText("Groups")
         .first()
         .click();

frontend/test/metabase/scenarios/admin/datamodel/field.cy.spec.js

@@ -144,7 +144,7 @@ describe("scenarios > admin > datamodel > field", () => {
       cy.contains("Title");
     });
 
-    it("lets you change to 'Custom mapping' and set custom values (Issue #12771)", () => {
+    it("lets you change to 'Custom mapping' and set custom values (metabase#12771)", () => {
       visitAlias("@ORDERS_QUANTITY_URL");
 
       cy.contains("Use original value").click();

frontend/test/metabase/scenarios/admin/settings/spinner.cy.spec.js

@@ -11,7 +11,7 @@ describe("scenarios > admin > spinner", () => {
       cy.findByText("Add Database").should("not.exist");
     });
 
-    it.skip("should not spin forever if it returns an error (Issue #11037)", () => {
+    it.skip("should not spin forever if it returns an error (metabase#11037)", () => {
       cy.visit("/admin/databases/999");
       cy.findAllByText("Databases").should("have.length", 2);
       cy.findByText("Loading...").should("not.exist");

frontend/test/metabase/scenarios/alert/email_alert.cy.spec.js

@@ -51,7 +51,7 @@ describe("scenarios > alert > email_alert", () => {
       });
     });
 
-    it("should have email alerts toggled off (Issue #12349)", () => {
+    it("should have email alerts toggled off (metabase#12349)", () => {
       // Turn off email alerts during alert setup
       setUpHourlyAlert(2);
       cy.findByText("Email")

frontend/test/metabase/scenarios/auth/search.cy.spec.js

@@ -16,7 +16,7 @@ describe("scenarios > auth > search", () => {
       cy.findByText("PRODUCTS");
     });
 
-    it("should work for user with permissions (Issue #12332)", () => {
+    it("should work for user with permissions (metabase#12332)", () => {
       signInAsNormalUser();
       cy.visit("/");
       cy.findByPlaceholderText("Search…").type("product{enter}");

frontend/test/metabase/scenarios/auth/signin.cy.spec.js

@@ -67,7 +67,7 @@ describe("scenarios > auth > signin", () => {
   });
 
   sizes.forEach(size => {
-    it(`should redirect from /auth/forgot_password back to /auth/login (viewport: ${size})`, () => {
+    it(`should redirect from /auth/forgot_password back to /auth/login (viewport: ${size}) (metabase#12658)`, () => {
       if (Cypress._.isArray(size)) {
         cy.viewport(size[0], size[1]);
       } else {

frontend/test/metabase/scenarios/dashboard/text-box.cy.spec.js

@@ -20,7 +20,7 @@ describe("scenarios > dashboard > text-box", () => {
       });
     });
 
-    it("should load after save/refresh (Issue #12914)", () => {
+    it("should load after save/refresh (metabase#12914)", () => {
       cy.visit(`/dashboard/2`);
 
       cy.findByText("Test Dashboard");
@@ -48,7 +48,7 @@ describe("scenarios > dashboard > text-box", () => {
       cy.findByText("Dashboard testing text");
     });
 
-    it.skip("should have a scroll bar for long text (Issue #8333)", () => {
+    it.skip("should have a scroll bar for long text (metabase#8333)", () => {
       cy.visit(`/dashboard/2`);
 
       // Add text box to dash

frontend/test/metabase/scenarios/question/custom_column.cy.spec.js

@@ -15,7 +15,7 @@ describe("scenarios > question > custom columns", () => {
   before(restore);
   beforeEach(signInAsNormalUser);
 
-  it.skip("cc should only apply to correct column (Issue #12649)", () => {
+  it.skip("cc should only apply to correct column (metabase#12649)", () => {
     // Create custom question
     cy.visit("/question/new");
     cy.findByText("Custom question").click();

frontend/test/metabase/scenarios/question/filter.cy.spec.js

@@ -9,7 +9,7 @@ describe("scenarios > question > filter", () => {
   before(restore);
   beforeEach(signInAsAdmin);
 
-  it.skip("should load needed data (Issue #12985)", () => {
+  it.skip("should load needed data (metabase#12985)", () => {
     // Save a Question
     openProductsTable();
     cy.findByText("Save").click();

frontend/test/metabase/scenarios/question/new.cy.spec.js

@@ -31,7 +31,7 @@ describe("scenarios > question > new", () => {
       cy.contains("37.65");
     });
 
-    it.skip("should remove `/notebook` from URL when converting question to SQL/Native (Issue #12651)", () => {
+    it.skip("should remove `/notebook` from URL when converting question to SQL/Native (metabase#12651)", () => {
       cy.server();
       cy.route("POST", "/api/dataset").as("dataset");
       openOrdersTable();
@@ -57,7 +57,7 @@ describe("scenarios > question > new", () => {
       cy.contains("37.65");
     });
 
-    it("should allow using `Custom Expression` in orders metrics", () => {
+    it("should allow using `Custom Expression` in orders metrics (metabase#12899)", () => {
       // go straight to "orders" in custom questions
       cy.visit("/question/new?database=1&table=2&mode=notebook");
       cy.findByText("Summarize").click();

frontend/test/metabase/scenarios/question/trendline.cy.spec.js

@@ -9,7 +9,7 @@ describe("scenarios > question > trendline", () => {
   before(restore);
   beforeEach(signInAsNormalUser);
 
-  it.skip("displays trendline when there are multiple numeric outputs (for simple question) (Issue #12781)", () => {
+  it.skip("displays trendline when there are multiple numeric outputs (for simple question) (metabase#12781)", () => {
     // Create question: orders summarized with "Average of Subtotal" and "Sum of Total" by CreatedAt:Year
     openOrdersTable();
     cy.get(".Icon-notebook").click();

frontend/test/metabase/scenarios/question/view.cy.spec.js

@@ -195,8 +195,7 @@ describe("scenarios > question > view", () => {
       });
     });
 
-    it.skip("should be able to filter Q by Category as no data user (from Q link)", () => {
-      // *** Test will fail until Issue #12654 is resolved
+    it.skip("should be able to filter Q by Category as no data user (from Q link) (metabase#12654)", () => {
       signIn("nodata");
       cy.visit("/question/4");
 
@@ -208,8 +207,7 @@ describe("scenarios > question > view", () => {
       cy.findByText("Gizmo").should("not.exist");
     });
 
-    it.skip("should be able to filter Q by Vendor as user (from Dashboard)", () => {
-      // *** Test will fail until Issue #12654 is resolved
+    it.skip("should be able to filter Q by Vendor as user (from Dashboard) (metabase#12654)", () => {
       // Navigate to Q from Dashboard
       signIn("nodata");
       cy.visit("/dashboard/2");

modules/drivers/bigquery/test/metabase/driver/bigquery/query_processor_test.clj

@@ -35,7 +35,7 @@
                              "LIMIT 2;")})))))
 
     (testing (str "make sure that BigQuery native queries maintain the column ordering specified in the SQL -- "
-                  "post-processing ordering shouldn't apply (Issue #2821)")
+                  "post-processing ordering shouldn't apply (metabase#2821)")
       (is (= [{:name         "venue_id"
                :display_name "venue_id"
                :source       :native
@@ -61,7 +61,7 @@
                  :type     :native
                  :database (mt/id)})))))
 
-    (testing "queries with array result columns deserialize properly (issue #10275)"
+    (testing "queries with array result columns deserialize properly (metabase#10275)"
       (is (= [[["foo" "bar"]
                [1 2]
                [3.14159265359 0.5772156649]

modules/drivers/oracle/src/metabase/driver/oracle.clj

@@ -203,7 +203,7 @@
 ;; )
 ;; WHERE __rownum__ >= 100;
 ;;
-;; See issue #3568 and the Oracle documentation for more details:
+;; See metabase#3568 and the Oracle documentation for more details:
 ;; http://docs.oracle.com/cd/B19306_01/server.102/b14200/pseudocolumns009.htm
 (defmethod sql.qp/apply-top-level-clause [:oracle :limit]
   [_ _ honeysql-query {value :limit}]

src/metabase/api/user.clj

@@ -182,7 +182,7 @@
     :is_active     true
     :is_superuser  false
     ;; if the user orignally logged in via Google Auth and it's no longer enabled, convert them into a regular user
-    ;; (see Issue #3323)
+    ;; (see metabase#3323)
     :google_auth   (boolean (and (:google_auth existing-user)
                                  ;; if google-auth-client-id is set it means Google Auth is enabled
                                  (session-api/google-auth-client-id)))

src/metabase/util.clj

@@ -384,7 +384,7 @@
   "Return a version of String `s` appropriate for use as a URL slug.
    Downcase the name, remove diacritcal marks, and replace non-alphanumeric *ASCII* characters with underscores;
    URL-encode non-ASCII characters. (Non-ASCII characters are encoded rather than replaced with underscores in order
-   to support languages that don't use the Latin alphabet; see issue #3818).
+   to support languages that don't use the Latin alphabet; see metabase#3818).
 
    Optionally specify `max-length` which will truncate the slug after that many characters."
   (^String [^String s]