Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
7321c3e2
Commit
7321c3e2
authored
7 years ago
by
Atte Keinänen
Browse files
Options
Downloads
Patches
Plain Diff
Fix binning drill-through
parent
7088192a
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
frontend/src/metabase/qb/lib/actions.js
+10
-5
10 additions, 5 deletions
frontend/src/metabase/qb/lib/actions.js
frontend/src/metabase/qb/lib/drilldown.js
+1
-14
1 addition, 14 deletions
frontend/src/metabase/qb/lib/drilldown.js
with
11 additions
and
19 deletions
frontend/src/metabase/qb/lib/actions.js
+
10
−
5
View file @
7321c3e2
/* @flow weak */
import
moment
from
"
moment
"
;
import
_
from
"
underscore
"
;
import
Q
from
"
metabase/lib/query
"
;
// legacy query lib
import
{
fieldIdsEq
}
from
"
metabase/lib/query/util
"
;
...
...
@@ -13,7 +14,8 @@ import { rangeForValue } from "metabase/lib/dataset";
import
{
isDate
,
isState
,
isCountry
isCountry
,
isCoordinate
}
from
"
metabase/lib/schema_metadata
"
;
import
Utils
from
"
metabase/lib/utils
"
;
...
...
@@ -399,10 +401,13 @@ const guessVisualization = (card: CardObject, tableMetadata: Table) => {
if
(
!
VISUALIZATIONS_TWO_BREAKOUTS
.
has
(
card
.
display
))
{
if
(
isDate
(
breakoutFields
[
0
]))
{
card
.
display
=
"
line
"
;
// NOTE Atte Keinänen 8/2/17: Heat/grid maps disabled in the first merged version of binning
// } else if (_.all(breakoutFields, isCoordinate)) {
// card.display = "map";
// card.visualization_settings["map.type"] = "grid";
}
else
if
(
_
.
all
(
breakoutFields
,
isCoordinate
))
{
card
.
display
=
"
map
"
;
// NOTE Atte Keinänen 8/2/17: Heat/grid maps disabled in the first merged version of binning
// Currently show a pin map instead of heat map for double coordinate breakout
// This way the binning drill-through works in a somewhat acceptable way (although it is designed for heat maps)
card
.
visualization_settings
[
"
map.type
"
]
=
"
pin
"
;
// card.visualization_settings["map.type"] = "grid";
}
else
{
card
.
display
=
"
bar
"
;
}
...
...
This diff is collapsed.
Click to expand it.
frontend/src/metabase/qb/lib/drilldown.js
+
1
−
14
View file @
7321c3e2
...
...
@@ -62,7 +62,7 @@ const DEFAULT_DRILL_DOWN_PROGRESSIONS = [
// generic num-bins drill down
[
[[
"
binning-strategy
"
,
isAny
,
"
num-bins
"
,
()
=>
true
]],
[[
"
binning-strategy
"
,
isAny
,
"
num-bins
"
,
previous
=>
previous
]]
[[
"
binning-strategy
"
,
isAny
,
"
default
"
]]
],
// generic bin-width drill down
[
...
...
@@ -213,19 +213,6 @@ function columnToBreakout(column) {
}
else
if
(
column
.
binning_info
)
{
let
binningStrategy
=
column
.
binning_info
.
binning_strategy
;
// HACK: `binning_strategy` currently always returns `num-bins`, so try to guess if it's actually `bin-width`
if
(
binningStrategy
===
"
num-bins
"
)
{
const
numBinsComputed
=
(
column
.
binning_info
.
max_value
-
column
.
binning_info
.
min_value
)
/
column
.
binning_info
.
bin_width
;
const
numBinsError
=
Math
.
abs
(
column
.
binning_info
.
num_bins
-
numBinsComputed
)
/
numBinsComputed
;
if
(
numBinsError
>
0.0000001
)
{
binningStrategy
=
"
bin-width
"
;
}
}
switch
(
binningStrategy
)
{
case
"
bin-width
"
:
return
[
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment