Remove `SaveQuestionModal.module.css` and replace with general CSS modules (#40500)

frontend/src/metabase/containers/SaveQuestionModal.module.css

-:global(.saveQuestionModalFields) {
-  overflow: hidden;
-}
-
-:global(.saveQuestionModalFields-enter) {
-  max-height: 0;
-}
-
-:global(.saveQuestionModalFields-enter.saveQuestionModalFields-enter-active) {
-  /* using 100% max-height breaks the transition */
-  max-height: 300px;
-  transition: max-height 500ms ease-out;
-}
-
-:global(.saveQuestionModalFields-exit) {
-  max-height: 300px;
-}
-
-:global(.saveQuestionModalFields-exit.saveQuestionModalFields-exit-active) {
-  max-height: 0;
-  transition: max-height 500ms ease-out;
-}

frontend/src/metabase/containers/SaveQuestionModal.tsx → frontend/src/metabase/containers/SaveQuestionModal/SaveQuestionModal.tsx

 import { useCallback, useMemo } from "react";
-import { CSSTransition, TransitionGroup } from "react-transition-group";
+import { TransitionGroup } from "react-transition-group";
 import { t } from "ttag";
 import * as Yup from "yup";
 
@@ -18,6 +18,7 @@ import FormInput from "metabase/core/components/FormInput";
 import FormRadio from "metabase/core/components/FormRadio";
 import FormSubmitButton from "metabase/core/components/FormSubmitButton";
 import FormTextArea from "metabase/core/components/FormTextArea";
+import CS from "metabase/css/core/index.css";
 import { Form, FormProvider } from "metabase/forms";
 import * as Errors from "metabase/lib/errors";
 import { useSelector } from "metabase/lib/redux";
@@ -30,8 +31,6 @@ import { Flex, Modal, DEFAULT_MODAL_Z_INDEX } from "metabase/ui";
 import type Question from "metabase-lib/v1/Question";
 import type { CollectionId } from "metabase-types/api";
 
-import "./SaveQuestionModal.module.css";
-
 const getLabels = (question: Question, showSaveType: boolean) => {
   const type = question.type();
 
@@ -255,31 +254,23 @@ export const SaveQuestionModal = ({
                     )}
                     <TransitionGroup>
                       {values.saveType === "create" && (
-                        <CSSTransition
-                          classNames="saveQuestionModalFields"
-                          timeout={{
-                            enter: 500,
-                            exit: 500,
-                          }}
-                        >
-                          <div className="saveQuestionModalFields">
-                            <FormInput
-                              name="name"
-                              title={t`Name`}
-                              placeholder={nameInputPlaceholder}
-                            />
-                            <FormTextArea
-                              name="description"
-                              title={t`Description`}
-                              placeholder={t`It's optional but oh, so helpful`}
-                            />
-                            <FormCollectionPicker
-                              name="collection_id"
-                              title={t`Which collection should this go in?`}
-                              zIndex={DEFAULT_MODAL_Z_INDEX + 1}
-                            />
-                          </div>
-                        </CSSTransition>
+                        <div className={CS.overflowHidden}>
+                          <FormInput
+                            name="name"
+                            title={t`Name`}
+                            placeholder={nameInputPlaceholder}
+                          />
+                          <FormTextArea
+                            name="description"
+                            title={t`Description`}
+                            placeholder={t`It's optional but oh, so helpful`}
+                          />
+                          <FormCollectionPicker
+                            name="collection_id"
+                            title={t`Which collection should this go in?`}
+                            zIndex={DEFAULT_MODAL_Z_INDEX + 1}
+                          />
+                        </div>
                       )}
                     </TransitionGroup>
                     <FormFooter>

frontend/src/metabase/containers/SaveQuestionModal/index.ts

+export * from "./SaveQuestionModal";