Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
761aa5e4
Commit
761aa5e4
authored
9 years ago
by
Allen Gilliland
Browse files
Options
Downloads
Plain Diff
Merge pull request #739 from metabase/sql_fix
Fix issues with SQL mode
parents
eecbedde
e42e500b
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
resources/frontend_client/app/query_builder/query.js
+7
-3
7 additions, 3 deletions
resources/frontend_client/app/query_builder/query.js
with
7 additions
and
3 deletions
resources/frontend_client/app/query_builder/query.js
+
7
−
3
View file @
761aa5e4
...
...
@@ -10,6 +10,10 @@ var Query = {
},
cleanQuery
:
function
(
query
)
{
if
(
!
query
)
{
return
query
;
}
// it's possible the user left some half-done parts of the query on screen when they hit the run button, so find those
// things now and clear them out so that we have a nice clean set of valid clauses in our query
...
...
@@ -55,7 +59,7 @@ var Query = {
},
hasValidBreakout
:
function
(
query
)
{
return
(
query
.
breakout
&&
return
(
query
&&
query
.
breakout
&&
query
.
breakout
.
length
>
0
&&
query
.
breakout
[
0
]
!==
null
);
},
...
...
@@ -90,8 +94,8 @@ var Query = {
},
hasValidAggregation
:
function
(
query
)
{
var
aggregation
=
query
.
aggregation
;
if
(
aggregation
!==
undefined
&&
var
aggregation
=
query
&&
query
.
aggregation
;
if
(
aggregation
&&
((
aggregation
.
length
===
1
&&
aggregation
[
0
]
!==
null
)
||
(
aggregation
.
length
===
2
&&
aggregation
[
0
]
!==
null
&&
aggregation
[
1
]
!==
null
)))
{
return
true
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment