-
- Downloads
Fix - Clicking Saved Questions option in data selector when instance have no...
Fix - Clicking Saved Questions option in data selector when instance have no questions leads to Raw Data option instead (#32173) * Fix #29760 * Refactor data types computation * Refactor DataPickerContainer - replace HOC entity loaders with hooks - extract useDataPickerConfig * Extract useDataPickerConfig * Use named exports * Move DATA_BUCKET to DataPicker container * Move DEFAULT_DATA_PICKER_FILTERS to constants * Update DATA_BUCKET to match DataPickerDataType * Use useDataPickerConfig in DataSelectorDataBucketPicker * Reuse DATA_BUCKET in DataPicker utils * Rename DataPickerContainer to DataPicker - refactor default export to named export * Sort imports * Fix import * Rename identifiers * Move database filtering out of useDataPickerConfig - Reuse DataTypeInfoItem type - Remove Bucket type - Make getDataTypes conditionally return raw data option * Simplify condition * Extract hasDataAccess out of useDataPickerConfig * Extract constants out of getDataTypes * Fix typo * Simplify approach, remove hooks * Improve diff * Lift getDataTypes call * Fix build * Add more DataSelectorDataBucketPicker unit tests * Remove unused hasUsableSavedQuestions * Extract utils unit tests * Extract setup function * Fix hasNestedQueriesEnabled selector * Fix onChangeDataBucket * Fix displaying saved questions * Add repro unit tests * Move constants to appropriate file * Use the same setup in tests * Fix typo * Make sure tests pass * Use data-testid instead of making assumptions about DOM structure
Showing
- frontend/src/metabase/containers/DataPicker/DataPickerContainer.tsx 3 additions, 3 deletions...rc/metabase/containers/DataPicker/DataPickerContainer.tsx
- frontend/src/metabase/containers/DataPicker/DataPickerView.tsx 5 additions, 2 deletions...end/src/metabase/containers/DataPicker/DataPickerView.tsx
- frontend/src/metabase/containers/DataPicker/DataTypePicker/DataTypePicker.tsx 1 addition, 2 deletions...e/containers/DataPicker/DataTypePicker/DataTypePicker.tsx
- frontend/src/metabase/containers/DataPicker/constants.ts 0 additions, 1 deletionfrontend/src/metabase/containers/DataPicker/constants.ts
- frontend/src/metabase/containers/DataPicker/constants.tsx 43 additions, 0 deletionsfrontend/src/metabase/containers/DataPicker/constants.tsx
- frontend/src/metabase/containers/DataPicker/index.ts 6 additions, 5 deletionsfrontend/src/metabase/containers/DataPicker/index.ts
- frontend/src/metabase/containers/DataPicker/tests/common.tsx 11 additions, 10 deletionsfrontend/src/metabase/containers/DataPicker/tests/common.tsx
- frontend/src/metabase/containers/DataPicker/types.ts 9 additions, 1 deletionfrontend/src/metabase/containers/DataPicker/types.ts
- frontend/src/metabase/containers/DataPicker/useDataPickerValue.ts 1 addition, 4 deletions.../src/metabase/containers/DataPicker/useDataPickerValue.ts
- frontend/src/metabase/containers/DataPicker/utils.ts 16 additions, 45 deletionsfrontend/src/metabase/containers/DataPicker/utils.ts
- frontend/src/metabase/containers/DataPicker/utils.unit.spec.ts 54 additions, 0 deletions...end/src/metabase/containers/DataPicker/utils.unit.spec.ts
- frontend/src/metabase/query_builder/components/DataSelector/DataSelector.jsx 27 additions, 9 deletions...se/query_builder/components/DataSelector/DataSelector.jsx
- frontend/src/metabase/query_builder/components/DataSelector/DataSelector.unit.spec.js 61 additions, 3 deletions...builder/components/DataSelector/DataSelector.unit.spec.js
- frontend/src/metabase/query_builder/components/DataSelector/DataSelectorDataBucketPicker/DataSelectorDataBucketPicker.tsx 40 additions, 56 deletions...SelectorDataBucketPicker/DataSelectorDataBucketPicker.tsx
- frontend/src/metabase/query_builder/components/DataSelector/DataSelectorDataBucketPicker/DataSelectorDataBucketPicker.unit.spec.tsx 33 additions, 2 deletions...taBucketPicker/DataSelectorDataBucketPicker.unit.spec.tsx
- frontend/src/metabase/query_builder/components/DataSelector/constants.ts 0 additions, 5 deletions...tabase/query_builder/components/DataSelector/constants.ts
- frontend/src/metabase/query_builder/components/notebook/steps/JoinStep/JoinStep.jsx 1 addition, 1 deletion...y_builder/components/notebook/steps/JoinStep/JoinStep.jsx
Loading
Please register or sign in to comment