Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
785d5017
Unverified
Commit
785d5017
authored
4 years ago
by
Paul Rosenzweig
Committed by
GitHub
4 years ago
Browse files
Options
Downloads
Patches
Plain Diff
Remove card id from questions updated by drills (#12960)
parent
69084dc6
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
frontend/src/metabase/visualizations/lib/utils.js
+1
-0
1 addition, 0 deletions
frontend/src/metabase/visualizations/lib/utils.js
frontend/test/metabase/scenarios/question/saved.cy.spec.js
+40
-0
40 additions, 0 deletions
frontend/test/metabase/scenarios/question/saved.cy.spec.js
with
41 additions
and
0 deletions
frontend/src/metabase/visualizations/lib/utils.js
+
1
−
0
View file @
785d5017
...
...
@@ -234,6 +234,7 @@ export function getCardAfterVisualizationClick(nextCard, previousCard) {
isMultiseriesQuestion
?
previousCard
.
id
:
nextCard
.
id
,
id
:
null
,
};
}
else
{
// Even though the card is currently clean, we might still apply dashboard parameters to it,
...
...
This diff is collapsed.
Click to expand it.
frontend/test/metabase/scenarios/question/saved.cy.spec.js
0 → 100644
+
40
−
0
View file @
785d5017
import
{
restore
,
signInAsNormalUser
,
popover
,
modal
,
}
from
"
__support__/cypress
"
;
describe
(
"
scenarios > question > saved
"
,
()
=>
{
before
(
restore
);
beforeEach
(
signInAsNormalUser
);
it
(
"
view and filter saved question
"
,
()
=>
{
cy
.
visit
(
"
/question/1
"
);
cy
.
findAllByText
(
"
Orders
"
);
// question and table name appears
// filter to only orders with quantity=100
cy
.
findByText
(
"
Quantity
"
).
click
();
popover
().
within
(()
=>
cy
.
findByText
(
"
Filter
"
).
click
());
popover
().
within
(()
=>
{
cy
.
findByPlaceholderText
(
"
Search the list
"
).
type
(
"
100
"
);
cy
.
findByText
(
"
Update filter
"
).
click
();
});
cy
.
findByText
(
"
Quantity is equal to 100
"
);
cy
.
findByText
(
"
Showing 2 rows
"
);
// query updated
// check that save will give option to replace
cy
.
findByText
(
"
Save
"
).
click
();
modal
().
within
(()
=>
{
cy
.
findByText
(
'
Replace original question, "Orders"
'
);
cy
.
findByText
(
"
Save as new question
"
);
cy
.
findByText
(
"
Cancel
"
).
click
();
});
// click "Started from Orders" and check that the original question is restored
cy
.
findByText
(
"
Started from
"
).
within
(()
=>
cy
.
findByText
(
"
Orders
"
).
click
());
cy
.
findByText
(
"
Showing first 2,000 rows
"
);
// query updated
cy
.
findByText
(
"
Started from
"
).
should
(
"
not.exist
"
);
cy
.
findByText
(
"
Quantity is equal to 100
"
).
should
(
"
not.exist
"
);
});
});
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment