Skip to content
Snippets Groups Projects
Unverified Commit 786a4b7e authored by Dalton's avatar Dalton Committed by GitHub
Browse files

only apply DataSelectorContainer css hack in QuestionDataSelector (#17676)

* only apply DataSelectorContainer hack in QuestionDataSelector

* unskip repro
parent 8dab3a31
No related branches found
No related tags found
No related merge requests found
......@@ -188,6 +188,7 @@ export class UnconnectedDataSelector extends Component {
tableFilter: PropTypes.func,
hasTableSearch: PropTypes.bool,
canChangeDatabase: PropTypes.bool,
containerClassName: PropTypes.string,
};
static defaultProps = {
......@@ -766,10 +767,10 @@ export class UnconnectedDataSelector extends Component {
return (
<PopoverWithTrigger
id="DataPopover"
containerClassName="DataPopoverContainer"
autoWidth
ref={this.popover}
isInitiallyOpen={this.props.isInitiallyOpen}
containerClassName={this.props.containerClassName}
triggerElement={this.getTriggerElement()}
triggerClasses={this.getTriggerClasses()}
horizontalAttachments={["center", "left", "right"]}
......
......@@ -6,6 +6,7 @@ import { DatabaseSchemaAndTableDataSelector } from "metabase/query_builder/compo
export default function QuestionDataSelector({ query, triggerElement }) {
return (
<DatabaseSchemaAndTableDataSelector
containerClassName="DataPopoverContainer"
hasTableSearch
databaseQuery={{ saved: true }}
selectedDatabaseId={query.databaseId()}
......
......@@ -6,7 +6,7 @@ import {
import * as SQLFilter from "../helpers/e2e-sql-filter-helpers";
describe.skip("issue 17490", () => {
describe("issue 17490", () => {
beforeEach(() => {
mockSessionProperty("field-filter-operators-enabled?", true);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment