[E2E] Fix and optimize repro for #17160 (#23792)

* Wait for the connected question to fully load

* Set default values for source dashboard filters

This step alone cuts the test execution time in half!

* Visit dashboards directly instead of hitting the `back` button

* Simplify function name

* Tidy up comments

* Wait for the target dashboard card to load

* Make setup function more explicit and more descriptive

* Make sure results loaded in a public source dashboard before testing click behavior

frontend/test/metabase/scenarios/dashboard/reproductions/17160-click-behavior-multiple-options.cy.spec.js

-import { restore, popover, visitDashboard } from "__support__/e2e/helpers";
-
+import { restore, visitDashboard } from "__support__/e2e/helpers";
 import { SAMPLE_DATABASE } from "__support__/e2e/cypress_sample_database";
 
 const { PRODUCTS, PRODUCTS_ID } = SAMPLE_DATABASE;
@@ -9,33 +8,36 @@ const CATEGORY_FILTER_PARAMETER_ID = "7c9ege62";
 
 describe("issue 17160", () => {
   beforeEach(() => {
+    cy.intercept("POST", "/api/card/*/query").as("cardQuery");
+
     restore();
     cy.signInAsAdmin();
   });
 
   it("should pass multiple filter values to questions and dashboards (metabase#17160-1)", () => {
-    setup(false);
-    cy.findByText("Category").click();
+    setupRegularDashboards();
 
-    popover().within(() => {
-      cy.findByText("Doohickey").click();
-      cy.findByText("Gadget").click();
-
-      cy.button("Add filter").click();
-    });
+    // 1. Check click behavior connected to a question
+    visitSourceDashboard();
 
-    // Check click behavior connected to a question
     cy.findAllByText("click-behavior-question-label").eq(0).click();
+    cy.wait("@cardQuery");
 
     cy.url().should("include", "/question");
 
     assertMultipleValuesFilterState();
 
-    // Go back to the dashboard
-    cy.go("back");
+    // 2. Check click behavior connected to a dashboard
+    visitSourceDashboard();
 
-    // Check click behavior connected to a dashboard
-    cy.findAllByText("click-behavior-dashboard-label").eq(0).click();
+    cy.get("@targetDashboardId").then(id => {
+      cy.intercept("POST", `/api/dashboard/${id}/dashcard/*/card/*/query`).as(
+        "targetDashcardQuery",
+      );
+
+      cy.findAllByText("click-behavior-dashboard-label").eq(0).click();
+      cy.wait("@targetDashcardQuery");
+    });
 
     cy.url().should("include", "/dashboard");
     cy.location("search").should("eq", "?category=Doohickey&category=Gadget");
@@ -45,43 +47,25 @@ describe("issue 17160", () => {
   });
 
   it("should pass multiple filter values to public questions and dashboards (metabase#17160-2)", () => {
-    setup(true);
+    setupPublicDashboards();
 
-    cy.icon("share").click();
-
-    // Open the dashboard public link
-    cy.findByText("Public link")
-      .parent()
-      .within(() => {
-        cy.get("input").then(input => {
-          cy.visit(input.val());
-        });
-      });
-
-    cy.findByText("Category").click();
-
-    popover().within(() => {
-      cy.findByText("Doohickey").click();
-      cy.findByText("Gadget").click();
-
-      cy.button("Add filter").click();
-    });
+    // 1. Check click behavior connected to a public question
+    visitPublicSourceDashboard();
 
-    // Check click behavior connected to a question
     cy.findAllByText("click-behavior-question-label").eq(0).click();
 
     cy.url().should("include", "/public/question");
 
     assertMultipleValuesFilterState();
 
-    // Go back to the dashboard
-    cy.go("back");
+    // 2. Check click behavior connected to a publicdashboard
+    visitPublicSourceDashboard();
 
-    // Check click behavior connected to a dashboard
     cy.findAllByText("click-behavior-dashboard-label").eq(0).click();
 
     cy.url().should("include", "/public/dashboard");
     cy.location("search").should("eq", "?category=Doohickey&category=Gadget");
+
     cy.findByText(TARGET_DASHBOARD_NAME);
 
     assertMultipleValuesFilterState();
@@ -123,7 +107,12 @@ function setup(shouldUsePublicLinks) {
     cy.createDashboard({ name: "17160D" }).then(
       ({ body: { id: dashboardId } }) => {
         // Share the dashboard
-        cy.request("POST", `/api/dashboard/${dashboardId}/public_link`);
+        cy.request("POST", `/api/dashboard/${dashboardId}/public_link`).then(
+          ({ body: { uuid } }) => {
+            cy.wrap(uuid).as("sourceDashboardUUID");
+          },
+        );
+        cy.wrap(dashboardId).as("sourceDashboardId");
 
         // Add the question to the dashboard
         cy.request("POST", `/api/dashboard/${dashboardId}/cards`, {
@@ -133,6 +122,7 @@ function setup(shouldUsePublicLinks) {
           cy.request("PUT", `/api/dashboard/${dashboardId}`, {
             parameters: [
               {
+                default: ["Doohickey", "Gadget"],
                 id: CATEGORY_FILTER_PARAMETER_ID,
                 name: "Category",
                 slug: "category",
@@ -142,7 +132,9 @@ function setup(shouldUsePublicLinks) {
             ],
           });
 
-          createTargetDashboardForClickBehavior().then(targetDashboardId => {
+          createTargetDashboard().then(targetDashboardId => {
+            cy.wrap(targetDashboardId).as("targetDashboardId");
+
             // Create a click behavior and resize the question card
             cy.request("PUT", `/api/dashboard/${dashboardId}/cards`, {
               cards: [
@@ -168,7 +160,6 @@ function setup(shouldUsePublicLinks) {
                 },
               ],
             });
-            visitDashboard(dashboardId);
           });
         });
       },
@@ -234,7 +225,7 @@ function getVisualSettingsWithClickBehavior(
   };
 }
 
-function createTargetDashboardForClickBehavior() {
+function createTargetDashboard() {
   return cy
     .createQuestionAndDashboard({
       dashboardDetails: {
@@ -263,7 +254,7 @@ function createTargetDashboardForClickBehavior() {
         ],
       });
 
-      // Create a click behavior and resize the question card
+      // Resize the question card and connect the filter to it
       return cy
         .request("PUT", `/api/dashboard/${dashboard_id}/cards`, {
           cards: [
@@ -289,3 +280,25 @@ function createTargetDashboardForClickBehavior() {
         });
     });
 }
+
+function setupRegularDashboards() {
+  return setup(false);
+}
+
+function setupPublicDashboards() {
+  return setup(true);
+}
+
+function visitSourceDashboard() {
+  cy.get("@sourceDashboardId").then(id => {
+    visitDashboard(id);
+  });
+}
+
+function visitPublicSourceDashboard() {
+  cy.get("@sourceDashboardUUID").then(uuid => {
+    cy.visit(`/public/dashboard/${uuid}`);
+
+    cy.findByTextEnsureVisible("Enormous Wool Car");
+  });
+}