-
- Downloads
Surface more column info (#39296)
* Add info icon to the column picker dropdown in the notebook editor (#38725) * Make SemanticTypeLabel not depend on Field but just on the semantic type * Add MLv2 version of FieldInfo * Add MLv2 props to FieldInfoPopover * Convert TableInteractive to use MLv2 version of FieldInfoPopover * Support Fingerprints in FieldInfo for MLv2 types * Move DateTimeFingerprint to its own file * Move NumberFingerprint to its own file * Allow Category finderprint info to work with MLv2 types * Remove null values in fingerprint info * Move move ColumnDescription into separate component * Split up fingerprint info component * Add hover card metadata to summarize sidebar (#38817) - Add column info hovercard to the summarize sidebar - Implement redesign of the bucker picker to accommodate the icon * Add hovercard on notebook filters (#38854) Add ColumnInfoIcon to the notebook filter picker * Add info popover to custom expression popover (#38870) * Pass query to ExpressionEditorSuggestions * Add info popover to custom expression suggestions * Add test for custom expression hovercard * Pass column directly instead of spreading it * Add unit test for suggestion list item * Add column info on filter modal (#38916) Add column info icon on the filter modal fields * Implement design feedback and fix tests (#39064) * Be more explicit with the icon position * Align the info icon more to the left * Directly export HoverParent * Ignore outside clicks on popover element * Fix binning tests * Select the correct popover * Fix import order * Fix broken export * Force click out of item * Fix missing bucket picker (#39244) * Data reference info hovercards (#39144) * Add info icons to fields in the data reference * Add test for info icon on field list * Render field items in a delay group * Fix import order to avoid circular dep * Force click item in test to avoid overlapping element * Add info icon to parameter field mapping (#39099) * Add info icon to dataselector * Add unit test for info icon * Fix import order to avoid circular dep * Ignore overlay when clicking element * Fix a circular dependency coming up in DataSelectorFieldPicker.unit.spec.tsx * Explicitlty import React * Fix text selector * Force click items to avoid overlapping elements from breaking the test * Avoid circular dependencies in entities/questions --------- Co-authored-by:Kamil Mielnik <kamil@kamilmielnik.com> * Join column hovercard (#38967) * Render Info icon on join column picker * Allow customising label on AccordionList * Add unit test for info icon on join column picker * Add info icon to summarize picker too * Fix margin on item name * Fix tests that rely on binning label * Set icon color without !important * Fix position of popover * Allow list item content to shrink where necessary * Make list item title ellipsified * Never shrink icon * Ignore overlay when clicking element * Fix import order to avoid circular dep * Reduce overlapping hovercards * Fix cut-off of text in summary column * Table info hovercard (#39308) * Use named export for TableInfoPopover * Remove duplicate propTypes * Export TableInfo's props * Use Mantine HoverCard for table info popover * Move info Popover to separate component * Move InfoIcon to shared component file * Add TableInfoIcon component * Add info icon to table picker * Pass through TableInfo props * Add test for TableInfoIcon * Use the info icon for the table header in chill mode * Pick the hovercard inside of the popover * Fix rendering children * Fix question test for table header * Avoid rendering huge icon in subtitle * Avoid unneccessary ternary Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Do not use within with single query Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Avoid cutting of loading spinner * Avoid closing popover when clicking it's content * Add test for click inside hovercard * Fix typo in commment Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Use direct import of ReactNode * Be more specific with popover selector * Scope selector to sidebar * Use correct selector for hovercard * Avoid scrollbars in info card * Adjust the width of the target component * Add more padding to description in table info card * Increase close delay to allow for clicks to go through * Simplify to findByText --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com> * Add DelayGroup to unpinned dimensions * Remove unused variable * Use getByText * Fix time popover closing when more... is clicked --------- Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
Showing
- e2e/support/helpers/e2e-ui-elements-helpers.js 2 additions, 2 deletionse2e/support/helpers/e2e-ui-elements-helpers.js
- e2e/test/scenarios/binning/binning-reproductions.cy.spec.js 4 additions, 2 deletionse2e/test/scenarios/binning/binning-reproductions.cy.spec.js
- e2e/test/scenarios/dashboard-filters/reproductions/27356-navigation-between-two-dashboards.cy.spec.js 2 additions, 2 deletions...ctions/27356-navigation-between-two-dashboards.cy.spec.js
- e2e/test/scenarios/filters/filter-bulk.cy.spec.js 18 additions, 4 deletionse2e/test/scenarios/filters/filter-bulk.cy.spec.js
- e2e/test/scenarios/joins/reproductions/23293-drill-through-implicit-join-add-remove-column.cy.spec.js 9 additions, 7 deletions...-drill-through-implicit-join-add-remove-column.cy.spec.js
- e2e/test/scenarios/question/new.cy.spec.js 13 additions, 0 deletionse2e/test/scenarios/question/new.cy.spec.js
- e2e/test/scenarios/question/notebook.cy.spec.js 49 additions, 17 deletionse2e/test/scenarios/question/notebook.cy.spec.js
- e2e/test/scenarios/question/saved.cy.spec.js 5 additions, 3 deletionse2e/test/scenarios/question/saved.cy.spec.js
- e2e/test/scenarios/question/summarization.cy.spec.js 2 additions, 2 deletionse2e/test/scenarios/question/summarization.cy.spec.js
- e2e/test/scenarios/sharing/public-sharing-embed-button-behavior.cy.spec.js 4 additions, 5 deletions...s/sharing/public-sharing-embed-button-behavior.cy.spec.js
- e2e/test/scenarios/visualizations-tabular/table.cy.spec.js 21 additions, 4 deletionse2e/test/scenarios/visualizations-tabular/table.cy.spec.js
- frontend/src/metabase-lib/expressions/suggest.ts 2 additions, 0 deletionsfrontend/src/metabase-lib/expressions/suggest.ts
- frontend/src/metabase/common/components/FieldPicker/FieldPicker.styled.tsx 29 additions, 22 deletions...base/common/components/FieldPicker/FieldPicker.styled.tsx
- frontend/src/metabase/common/components/FieldPicker/FieldPicker.tsx 32 additions, 19 deletions...rc/metabase/common/components/FieldPicker/FieldPicker.tsx
- frontend/src/metabase/common/components/QueryColumnPicker/BucketPickerPopover/BaseBucketPickerPopover.styled.tsx 27 additions, 4 deletions...er/BucketPickerPopover/BaseBucketPickerPopover.styled.tsx
- frontend/src/metabase/common/components/QueryColumnPicker/BucketPickerPopover/BaseBucketPickerPopover.tsx 14 additions, 2 deletions...umnPicker/BucketPickerPopover/BaseBucketPickerPopover.tsx
- frontend/src/metabase/common/components/QueryColumnPicker/BucketPickerPopover/types.ts 7 additions, 1 deletion...components/QueryColumnPicker/BucketPickerPopover/types.ts
- frontend/src/metabase/common/components/QueryColumnPicker/QueryColumnPicker.styled.tsx 26 additions, 0 deletions...components/QueryColumnPicker/QueryColumnPicker.styled.tsx
- frontend/src/metabase/common/components/QueryColumnPicker/QueryColumnPicker.tsx 72 additions, 36 deletions...common/components/QueryColumnPicker/QueryColumnPicker.tsx
- frontend/src/metabase/common/components/QueryColumnPicker/QueryColumnPicker.unit.spec.tsx 10 additions, 0 deletions...ponents/QueryColumnPicker/QueryColumnPicker.unit.spec.tsx
Loading
Please register or sign in to comment