Skip to content
Snippets Groups Projects
Unverified Commit 798c81a7 authored by Aleksandr Lesnenko's avatar Aleksandr Lesnenko Committed by GitHub
Browse files

fix hidden pivot table scroll bar in QB (#47629)


* fix hidden pivot table scroll bar in QB

* Update Loki Snapshots

* Update Loki Snapshots

---------

Co-authored-by: default avatarMetabase Automation <github-automation@metabase.com>
parent 03aff864
No related branches found
No related tags found
No related merge requests found
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png

67.8 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png

67.8 KiB | W: | H:

.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png
.loki/reference/chrome_laptop_embed_PublicOrEmbeddedDashboardView_filters_Dark_Theme_Number.png
  • 2-up
  • Swipe
  • Onion skin
.loki/reference/chrome_laptop_viz_PivotTable_No_Outer_Horizontal_Scroll.png

9.94 KiB

......@@ -60,6 +60,7 @@ export const HorizontalScroll43215: Story = () => {
<PivotTableTestWrapper
data={PIVOT_3_ROWS_NO_COLUMNS.data}
initialSettings={PIVOT_3_ROWS_NO_COLUMNS.initialSettings}
isEditing
/>
</Box>
</VisualizationWrapper>
......@@ -75,6 +76,24 @@ export const OuterHorizontalScroll: Story = () => {
initialSettings={PIVOT_3_ROWS_NO_COLUMNS.initialSettings}
containerWidth
containerHeight
isEditing
/>
</Box>
</VisualizationWrapper>
);
};
export const NoOuterHorizontalScroll: Story = () => {
return (
<VisualizationWrapper>
<Box h="400px" w="320px">
<PivotTableTestWrapper
data={PIVOT_3_ROWS_NO_COLUMNS.data}
initialSettings={PIVOT_3_ROWS_NO_COLUMNS.initialSettings}
containerWidth
containerHeight
isEditing
isDashboard
/>
</Box>
</VisualizationWrapper>
......
......@@ -147,7 +147,7 @@ interface PivotTableRootProps {
isDashboard?: boolean;
isNightMode?: boolean;
shouldOverflow?: boolean;
isEditing?: boolean;
shouldHideScrollbars?: boolean;
}
export const PivotTableRoot = styled.div<PivotTableRootProps>`
......@@ -164,7 +164,7 @@ export const PivotTableRoot = styled.div<PivotTableRootProps>`
: null}
${props =>
props.isEditing
props.shouldHideScrollbars
? css`
& {
user-select: none;
......
......@@ -346,7 +346,7 @@ function _PivotTable({
return (
<PivotTableRoot
shouldOverflow={shouldOverflow}
isEditing={isEditing}
shouldHideScrollbars={isEditing && isDashboard}
isDashboard={isDashboard}
isNightMode={isNightMode}
data-testid="pivot-table"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment