Move parameter types to `metabase-lib` (#26009)

* Move parameter types to metabase-lib

* Add type to imports

* move remaining parameter-type util over to metabase-lib

frontend/src/metabase/parameters/mock.ts → frontend/src/metabase-lib/lib/parameters/mock.ts

-import { UiParameter } from "metabase/parameters/types";
+import { UiParameter } from "metabase-lib/lib/parameters/types";
 
 export const createMockUiParameter = (
   opts?: Partial<UiParameter>,

frontend/src/metabase/parameters/types.ts → frontend/src/metabase-lib/lib/parameters/types.ts

-import { Parameter, ParameterTarget } from "metabase-types/types/Parameter";
-import Field from "metabase-lib/lib/metadata/Field";
+import type {
+  Parameter,
+  ParameterTarget,
+} from "metabase-types/types/Parameter";
+import type Field from "metabase-lib/lib/metadata/Field";
 
 export interface ValuePopulatedParameter extends Parameter {
   value?: any;

frontend/src/metabase-lib/lib/parameters/utils/operators.unit.spec.ts

-import { createMockUiParameter } from "metabase/parameters/mock";
+import { createMockUiParameter } from "metabase-lib/lib/parameters/mock";
 
 import {
   getOperatorDisplayName,

frontend/src/metabase-lib/lib/parameters/utils/parameter-type.ts

 import _ from "underscore";
 import { Parameter } from "metabase-types/types/Parameter";
+import { FieldFilterUiParameter } from "metabase-lib/lib/parameters/types";
+import { FIELD_FILTER_PARAMETER_TYPES } from "metabase-lib/lib/parameters/constants";
 
 export function getParameterType(parameter: Parameter | string) {
   return typeof parameter === "string"
@@ -34,3 +36,10 @@ export function isStringParameter(parameter: Parameter) {
   const type = getParameterType(parameter);
   return type === "string";
 }
+
+export function isFieldFilterParameter(
+  parameter: Parameter,
+): parameter is FieldFilterUiParameter {
+  const type = getParameterType(parameter);
+  return FIELD_FILTER_PARAMETER_TYPES.includes(type);
+}

frontend/src/metabase-lib/lib/parameters/utils/template-tags.ts

 import _ from "underscore";
 
-import type { ParameterWithTarget } from "metabase/parameters/types";
 import type {
   Parameter,
   ParameterTarget,
 } from "metabase-types/types/Parameter";
 import type { Card } from "metabase-types/types/Card";
 import type { TemplateTag } from "metabase-types/types/Query";
+import type { ParameterWithTarget } from "metabase-lib/lib/parameters/types";
 import { getTemplateTagFromTarget } from "metabase-lib/lib/parameters/utils/targets";
 import { hasParameterValue } from "metabase-lib/lib/parameters/utils/parameter-values";
 

frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ActionOptions/ActionClickMappings.tsx

@@ -8,7 +8,7 @@ import type {
   ClickBehaviorParameterMapping,
   WritebackAction,
 } from "metabase-types/api";
-import type { UiParameter } from "metabase/parameters/types";
+import type { UiParameter } from "metabase-lib/lib/parameters/types";
 
 import {
   turnClickBehaviorParameterMappingsIntoDashCardMappings,

frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ActionOptions/ActionOptions.tsx

@@ -11,7 +11,7 @@ import type {
   WritebackAction,
 } from "metabase-types/api";
 import type { State } from "metabase-types/store";
-import type { UiParameter } from "metabase/parameters/types";
+import type { UiParameter } from "metabase-lib/lib/parameters/types";
 
 import { SidebarContent } from "../ClickBehaviorSidebar.styled";
 

frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ActionOptions/utils.ts

@@ -8,7 +8,7 @@ import type {
   WritebackAction,
   WritebackParameter,
 } from "metabase-types/api";
-import type { UiParameter } from "metabase/parameters/types";
+import type { UiParameter } from "metabase-lib/lib/parameters/types";
 
 export function turnDashCardParameterMappingsIntoClickBehaviorMappings(
   dashCard: ActionDashboardCard,

frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ActionOptions/utils.unit.spec.ts

@@ -3,12 +3,12 @@ import type {
   ClickBehaviorParameterMapping,
   WritebackParameter,
 } from "metabase-types/api";
-import type { UiParameter } from "metabase/parameters/types";
-
 import {
   createMockDashboardActionButton,
   createMockQueryAction,
 } from "metabase-types/api/mocks";
+import type { UiParameter } from "metabase-lib/lib/parameters/types";
+
 import {
   turnClickBehaviorParameterMappingsIntoDashCardMappings,
   turnDashCardParameterMappingsIntoClickBehaviorMappings,

frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ClickBehaviorSidebar.tsx

@@ -8,7 +8,6 @@ import Sidebar from "metabase/dashboard/components/Sidebar";
 
 import { isMappedExplicitActionButton } from "metabase/writeback/utils";
 
-import type { UiParameter } from "metabase/parameters/types";
 import type {
   Dashboard,
   DashboardOrderedCard,
@@ -19,6 +18,7 @@ import type {
   DatasetColumn,
 } from "metabase-types/api";
 import { isTableDisplay } from "metabase/lib/click-behavior";
+import type { UiParameter } from "metabase-lib/lib/parameters/types";
 import { clickBehaviorIsValid } from "metabase-lib/lib/parameters/utils/click-behavior";
 
 import { getColumnKey } from "metabase-lib/lib/queries/utils/get-column-key";

frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ClickBehaviorSidebarContent.tsx

@@ -3,7 +3,6 @@ import { getIn } from "icepick";
 
 import { isMappedExplicitActionButton } from "metabase/writeback/utils";
 
-import type { UiParameter } from "metabase/parameters/types";
 import type {
   Dashboard,
   DashboardOrderedCard,
@@ -15,6 +14,7 @@ import type {
 } from "metabase-types/api";
 
 import { isTableDisplay } from "metabase/lib/click-behavior";
+import type { UiParameter } from "metabase-lib/lib/parameters/types";
 import { getClickBehaviorForColumn } from "./utils";
 import ClickBehaviorSidebarMainView from "./ClickBehaviorSidebarMainView";
 import TableClickBehaviorView from "./TableClickBehaviorView";

frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ClickBehaviorSidebarMainView/ClickBehaviorSidebarMainView.tsx

 import React from "react";
 
-import type { UiParameter } from "metabase/parameters/types";
 import type {
   ActionDashboardCard,
   Dashboard,
   DashboardOrderedCard,
   ClickBehavior,
 } from "metabase-types/api";
+import type { UiParameter } from "metabase-lib/lib/parameters/types";
 
 import { clickBehaviorOptions, getClickBehaviorOptionName } from "../utils";
 import ActionOptions from "../ActionOptions";

frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/CustomURLPicker.tsx

@@ -5,13 +5,13 @@ import InputBlurChange from "metabase/components/InputBlurChange";
 import ModalContent from "metabase/components/ModalContent";
 import ModalWithTrigger from "metabase/components/ModalWithTrigger";
 
-import type { UiParameter } from "metabase/parameters/types";
 import type {
   ArbitraryCustomDestinationClickBehavior,
   ClickBehavior,
   DashboardOrderedCard,
 } from "metabase-types/api";
 import { isTableDisplay } from "metabase/lib/click-behavior";
+import type { UiParameter } from "metabase-lib/lib/parameters/types";
 import { clickBehaviorIsValid } from "metabase-lib/lib/parameters/utils/click-behavior";
 
 import { SidebarItem } from "../SidebarItem";

frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/LinkOptions/LinkOptions.tsx

 import React, { useCallback } from "react";
 import { t } from "ttag";
 
-import type { UiParameter } from "metabase/parameters/types";
 import type {
   DashboardOrderedCard,
   ArbitraryCustomDestinationClickBehavior,
@@ -10,6 +9,7 @@ import type {
   CustomDestinationClickBehaviorLinkType,
 } from "metabase-types/api";
 import { isTableDisplay } from "metabase/lib/click-behavior";
+import type { UiParameter } from "metabase-lib/lib/parameters/types";
 import { SidebarContent } from "../ClickBehaviorSidebar.styled";
 import CustomLinkText from "./CustomLinkText";
 import LinkedEntityPicker from "./LinkedEntityPicker";

frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TypeSelector/TypeSelector.tsx

@@ -5,8 +5,8 @@ import { color } from "metabase/lib/colors";
 
 import { isActionDashCard } from "metabase/writeback/utils";
 
-import type { UiParameter } from "metabase/parameters/types";
 import type { DashboardOrderedCard, ClickBehavior } from "metabase-types/api";
+import type { UiParameter } from "metabase-lib/lib/parameters/types";
 
 import { clickBehaviorOptions, getClickBehaviorOptionName } from "../utils";
 import { SidebarItem } from "../SidebarItem";

frontend/src/metabase/parameters/components/FormattedParameterValue/FormattedParameterValue.tsx

 import React from "react";
 
 import { formatParameterValue } from "metabase/parameters/utils/formatting";
-import { UiParameter, FieldFilterUiParameter } from "metabase/parameters/types";
 import ParameterFieldWidgetValue from "metabase/parameters/components/widgets/ParameterFieldWidget/ParameterFieldWidgetValue/ParameterFieldWidgetValue";
+import {
+  UiParameter,
+  FieldFilterUiParameter,
+} from "metabase-lib/lib/parameters/types";
 import { isDateParameter } from "metabase-lib/lib/parameters/utils/parameter-type";
 
 type FormattedParameterValueProps = {

frontend/src/metabase/parameters/utils/cards.ts

 import _ from "underscore";
 
-import { ParameterWithTarget, UiParameter } from "metabase/parameters/types";
 import { Parameter, ParameterTarget } from "metabase-types/types/Parameter";
 import { Card } from "metabase-types/types/Card";
+import {
+  ParameterWithTarget,
+  UiParameter,
+} from "metabase-lib/lib/parameters/types";
 import { getValuePopulatedParameters } from "metabase-lib/lib/parameters/utils/parameter-values";
 import { getParameterTargetField } from "metabase-lib/lib/parameters/utils/targets";
 import Question from "metabase-lib/lib/Question";

frontend/src/metabase/parameters/utils/dashboards.ts

 import _ from "underscore";
 
 import { generateParameterId } from "metabase/parameters/utils/parameter-id";
-import { isFieldFilterParameter } from "metabase/parameters/utils/parameter-type";
 import { slugify } from "metabase/lib/formatting";
-import type {
-  UiParameter,
-  FieldFilterUiParameter,
-  ParameterWithTarget,
-} from "metabase/parameters/types";
 import type {
   Parameter,
   ParameterMappingOptions,
@@ -18,6 +12,12 @@ import type {
   DashboardOrderedCard,
 } from "metabase-types/api";
 import type { SavedCard } from "metabase-types/types/Card";
+import { isFieldFilterParameter } from "metabase-lib/lib/parameters/utils/parameter-type";
+import type {
+  UiParameter,
+  FieldFilterUiParameter,
+  ParameterWithTarget,
+} from "metabase-lib/lib/parameters/types";
 import {
   getTargetFieldFromCard,
   isVariableTarget,

frontend/src/metabase/parameters/utils/date-formatting.ts

@@ -12,7 +12,7 @@ import {
   getStartingFrom,
 } from "metabase-lib/lib/queries/utils/query-time";
 
-import { UiParameter } from "../types";
+import { UiParameter } from "metabase-lib/lib/parameters/types";
 
 // Use a placeholder value as field references are not used in dashboard filters
 const noopRef = null;

frontend/src/metabase/parameters/utils/fields.ts

-import { UiParameter } from "metabase/parameters/types";
+import { UiParameter } from "metabase-lib/lib/parameters/types";
 
 export function hasFieldValues(parameter: UiParameter) {
   if ("fields" in parameter) {