Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
7b1ff963
Unverified
Commit
7b1ff963
authored
6 years ago
by
Cam Saul
Browse files
Options
Downloads
Patches
Plain Diff
If sending a Slack pulse/alert fails, still send email pulse/alert (#7409)
parent
bf9f1023
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/metabase/pulse.clj
+7
-3
7 additions, 3 deletions
src/metabase/pulse.clj
with
7 additions
and
3 deletions
src/metabase/pulse.clj
+
7
−
3
View file @
7b1ff963
...
...
@@ -15,8 +15,7 @@
[
metabase.util
[
ui-logic
:as
ui
]
[
urls
:as
urls
]]
[
metabase.util.urls
:as
urls
]
[
puppetlabs.i18n.core
:refer
[
tru
]]
[
puppetlabs.i18n.core
:refer
[
trs
tru
]]
[
schema.core
:as
s
]
[
toucan.db
:as
db
])
(
:import
java.util.TimeZone
...
...
@@ -212,7 +211,12 @@
(
defn-
send-notifications!
[
notifications
]
(
doseq
[
notification
notifications
]
(
send-notification!
notification
)))
;; do a try-catch around each notification so if one fails, we'll still send the other ones for example, an Alert
;; set up to send over both Slack & email: if Slack fails, we still want to send the email (#7409)
(
try
(
send-notification!
notification
)
(
catch
Throwable
e
(
log/error
e
(
trs
"Error sending notification!"
))))))
(
defn-
pulse->notifications
[{
:keys
[
cards
channel-ids
]
,
:as
pulse
}]
(
let
[
results
(
for
[
card
cards
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment