Skip to content

GitLab

Explore

Sign in

Primary navigation

Project

M

Metabase
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Environments
- Terraform modules
- Incidents
- Service Desk

Snippets Groups Projects

7b22f82d

Unverified Commit 7b22f82d authored 5 years ago by Tom Robinson Committed by GitHub 5 years ago

Downloads
- Patches
- Plain Diff

Fix notebook query cleaning (#11792) (#11798)

* Fix notebook query cleaning, add tests/docs/flow types for steps.js. Resolves #11334

parent 228a5fe2

Branches

Tags

No related merge requests found

Changes 5

Hide whitespace changes

Inline Side-by-side

Showing

frontend/src/metabase-lib/lib/queries/StructuredQuery.js 40 additions, 20 deletions

frontend/src/metabase-lib/lib/queries/StructuredQuery.js
frontend/src/metabase/query_builder/components/notebook/NotebookSteps.jsx 1 addition, 6 deletions

...abase/query_builder/components/notebook/NotebookSteps.jsx
frontend/src/metabase/query_builder/components/notebook/lib/steps.js 142 additions, 15 deletions

...c/metabase/query_builder/components/notebook/lib/steps.js
frontend/test/metabase-lib/lib/queries/StructuredQuery-clean.unit.spec.js 42 additions, 1 deletion

...tabase-lib/lib/queries/StructuredQuery-clean.unit.spec.js
frontend/test/metabase/query_builder/components/notebook/lib/steps.unit.spec.js 188 additions, 16 deletions

.../query_builder/components/notebook/lib/steps.unit.spec.js

with 413 additions and 58 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment